content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: fixing tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.h ('K') | « content/browser/renderer_host/input/touch_selection_controller_client_aura.cc ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index a473ac5ae4d344ee98ca36ead58328dff44b4e07..a672668d4b6b85621cb590d66d3648c61ee4508d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1680,10 +1680,11 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

}

@CalledByNative

- private void showPastePopup(

- int left, int top, int right, int bottom, boolean canSelectAll, boolean canEditRichly) {

- mSelectionPopupController.createAndShowPastePopup(

- left, top, right, bottom, canSelectAll, canEditRichly);

+ private void showSelectionMenu(int left, int top, int right, int bottom, boolean isEditable,

+ boolean isPasswordType, String selectionText, boolean canSelectAll,

+ boolean canEditRichly, boolean shouldSuggest) {

+ mSelectionPopupController.showSelectionMenu(left, top, right, bottom, isEditable,

+ isPasswordType, selectionText, canSelectAll, canEditRichly, shouldSuggest);

}

private void destroyPastePopup() {