content/public/android/java/src/org/chromium/content/browser/SelectionClient.java - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: Fixing rebase bug Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java ('k') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

index 7c9a844914f480ab7af0c7bab822fedf82dbb7e1..1f56b4808a582a53884aa0531fb9c5d9a86c4180 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

@@ -34,5 +34,5 @@ public interface SelectionClient {

* the context menu (e.g. that we need a new menu item). In this case an embedder might want

* to wait for this responce before taking further actions.

- boolean sendsSelectionPopupUpdates();

+ boolean sendsSelectionPopupUpdates(boolean shouldSuggest);

Jinsuk Kim 2017/04/24 06:33:16 Update javadoc.

}