content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: Fixing rebase bug Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/touch_emulator_client.h ('K') | « content/common/frame_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 68d484b08d3fa8644d8b3d7f837068f86a9549ff..9df6c76fdc7e0e06673ca7ca3c5d75a1ec4d60cd 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1783,8 +1783,11 @@ public class ContentViewCore

}

@CalledByNative

- private void showPastePopup(int x, int y, boolean canSelectAll) {

- mSelectionPopupController.createAndShowPastePopup(x, y, canSelectAll);

+ private void showSelectionMenu(int xAnchor, int yAnchor, int left, int top, int right,

+ int bottom, boolean isEditable, boolean isPasswordType, String selectionText,

+ boolean canSelectAll) {

+ mSelectionPopupController.showSelectionMenu(xAnchor, yAnchor, left, top, right, bottom,

+ isEditable, isPasswordType, selectionText, canSelectAll);

}

private void destroyPastePopup() {