chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: Fixing rebase bug Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/browser/android/content_view_core_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

diff --git a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

index f7a56836ebbf21422cac332802caa36c266766a0..2f525e05c1598ae92b20aa2ba10612541aedb887 100644

--- a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

+++ b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

@@ -32,7 +32,7 @@ void ChromeWebContentsViewDelegateAndroid::ShowContextMenu(

const content::ContextMenuParams& params) {

content::ContentViewCore* content_view_core =

content::ContentViewCore::FromWebContents(web_contents_);

- if (content_view_core && content_view_core->ShowPastePopup(params))

+ if (content_view_core && content_view_core->ShowSelectionMenu(params))

return;

// TODO(dtrainor, kouhei): Give WebView a Populator/delegate so it can use