Selection Action mode triggered like a context menu

third_party/WebKit/Source/core/editing/SelectionController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 23 matching lines @@
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/RenderedPosition.h"
 #include "core/editing/iterators/TextIterator.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/events/Event.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
+#include "core/input/EventHandler.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/page/FocusController.h"
 #include "core/page/Page.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/wtf/AutoReset.h"
+#include "public/web/WebMenuSourceType.h"
 
 namespace blink {
 SelectionController* SelectionController::Create(LocalFrame& frame) {
   return new SelectionController(frame);
 }
 
 SelectionController::SelectionController(LocalFrame& frame)
     : frame_(&frame),
       mouse_down_may_start_select_(false),
       mouse_down_was_single_click_in_selection_(false),
@@ skipping 127 matching lines @@
         FlooredIntPoint(event.Event().PositionInRootFrame()));
     if (!extend_selection && this->Selection().Contains(v_point)) {
       mouse_down_was_single_click_in_selection_ = true;
       if (!event.Event().FromTouch())
         return false;
 
       if (!this->Selection().IsHandleVisible()) {
         UpdateSelectionForMouseDownDispatchingSelectStart(
             inner_node, selection, kCharacterGranularity,
             HandleVisibility::kVisible);
+        frame_->GetEventHandler().ShowNonLocatedContextMenu(nullptr,

[yosin_UTC9, 2017/05/25 04:47:20]

Since "selectionstart" event is cancelalbe, we should now show context menu if
"selectionstart" event is canceled.

[amaralp1, 2017/05/25 07:11:56]

Changed to only show context menu if
|UpdateSelectionForMouseDownDispatchingSelectStart()| returns true.

+                                                            kMenuSourceTouch);

[yosin_UTC9, 2017/05/25 04:47:21]

Could you tell me why we use |kMenuSourceTouch| even if mouse single click?
Should we check |event.FromTouch()|?

[amaralp1, 2017/05/25 07:11:56]

|event.FromTouch()| has to be true or else we would have returned in the
previous if statement:

if (!event.Event().FromTouch())
  return false;

         return false;
       }
     }
   }
 
   if (extend_selection && !selection.IsNone()) {
     // Note: "fast/events/shift-click-user-select-none.html" makes
     // |pos.isNull()| true.
     const PositionInFlatTree& pos = AdjustPositionRespectUserSelectAll(
         inner_node, selection.Start(), selection.end(),
@@ skipping 329 matching lines @@
 
   if (append_trailing_whitespace == AppendTrailingWhitespace::kShouldAppend)
     new_selection.AppendTrailingWhitespace();
 
   UpdateSelectionForMouseDownDispatchingSelectStart(
       inner_node,
       ExpandSelectionToRespectUserSelectAll(inner_node, new_selection),
       kWordGranularity, HandleVisibility::kNotVisible);
 }
 
-void SelectionController::SelectClosestWordFromMouseEvent(
+bool SelectionController::SelectClosestWordFromMouseEvent(
     const MouseEventWithHitTestResults& result) {
   if (!mouse_down_may_start_select_)
-    return;
+    return false;
 
   AppendTrailingWhitespace append_trailing_whitespace =
       (result.Event().click_count == 2 &&
        frame_->GetEditor().IsSelectTrailingWhitespaceEnabled())
           ? AppendTrailingWhitespace::kShouldAppend
           : AppendTrailingWhitespace::kDontAppend;
 
   DCHECK(!frame_->GetDocument()->NeedsLayoutTreeUpdate());
 
-  SelectClosestWordFromHitTestResult(
+  return SelectClosestWordFromHitTestResult(
       result.GetHitTestResult(), append_trailing_whitespace,
       result.Event().FromTouch() ? SelectInputEventType::kTouch
                                  : SelectInputEventType::kMouse);
 }
 
 void SelectionController::SelectClosestMisspellingFromMouseEvent(
     const MouseEventWithHitTestResults& result) {
   if (!mouse_down_may_start_select_)
     return;
 
   SelectClosestMisspellingFromHitTestResult(
       result.GetHitTestResult(),
       (result.Event().click_count == 2 &&
        frame_->GetEditor().IsSelectTrailingWhitespaceEnabled())
           ? AppendTrailingWhitespace::kShouldAppend
           : AppendTrailingWhitespace::kDontAppend);
 }
 
 void SelectionController::SelectClosestWordOrLinkFromMouseEvent(
     const MouseEventWithHitTestResults& result) {
-  if (!result.GetHitTestResult().IsLiveLink())
-    return SelectClosestWordFromMouseEvent(result);
+  if (!result.GetHitTestResult().IsLiveLink()) {
+    SelectClosestWordFromMouseEvent(result);
+    return;
+  }
 
   Node* inner_node = result.InnerNode();
 
   if (!inner_node || !inner_node->GetLayoutObject() ||
       !mouse_down_may_start_select_)
     return;
 
   VisibleSelectionInFlatTree new_selection;
   Element* url_element = result.GetHitTestResult().URLElement();
   const VisiblePositionInFlatTree pos =
@@ skipping 164 matching lines @@
     return false;
 
   if (Selection().ComputeVisibleSelectionInDOMTreeDeprecated().IsRange()) {
     // A double-click when range is already selected
     // should not change the selection.  So, do not call
     // selectClosestWordFromMouseEvent, but do set
     // m_beganSelectingText to prevent handleMouseReleaseEvent
     // from setting caret selection.
     selection_state_ = SelectionState::kExtendedSelection;
   } else {
-    SelectClosestWordFromMouseEvent(event);
+    const bool did_select = SelectClosestWordFromMouseEvent(event);
+    if (did_select && Selection().IsHandleVisible()) {
+      frame_->GetEventHandler().ShowNonLocatedContextMenu(nullptr,
+                                                          kMenuSourceTouch);
+    }
   }
   return true;
 }
 
 bool SelectionController::HandleTripleClick(
     const MouseEventWithHitTestResults& event) {
   TRACE_EVENT0("blink",
                "SelectionController::handleMousePressEventTripleClick");
 
   if (!Selection().IsAvailable()) {
@@ skipping 19 matching lines @@
     new_selection =
         CreateVisibleSelection(SelectionInFlatTree::Builder()
                                    .Collapse(pos.ToPositionWithAffinity())
                                    .SetGranularity(kParagraphGranularity)
                                    .Build());
   }
 
   const bool is_handle_visible =
       event.Event().FromTouch() && new_selection.IsRange();
 
-  return UpdateSelectionForMouseDownDispatchingSelectStart(
+  const bool did_select = UpdateSelectionForMouseDownDispatchingSelectStart(
       inner_node,
       ExpandSelectionToRespectUserSelectAll(inner_node, new_selection),
       kParagraphGranularity,
       is_handle_visible ? HandleVisibility::kVisible
                         : HandleVisibility::kNotVisible);
+  if (did_select && Selection().IsHandleVisible()) {

[yosin_UTC9, 2017/05/25 04:47:20]

early-return style is better.

if (!did_selection)
  return false;

if (Selection().IsHandleVisible()) {
  ShwoNonLocatedCotnextMenu(...)
}

return true;

[amaralp1, 2017/05/25 07:11:56]

Done.

+    frame_->GetEventHandler().ShowNonLocatedContextMenu(nullptr,
+                                                        kMenuSourceTouch);
+  }
+  return did_select;
 }
 
 bool SelectionController::HandleMousePressEvent(
     const MouseEventWithHitTestResults& event) {
   TRACE_EVENT0("blink", "SelectionController::handleMousePressEvent");
 
   // If we got the event back, that must mean it wasn't prevented,
   // so it's allowed to start a drag or selection if it wasn't in a scrollbar.
   mouse_down_may_start_select_ =
       (CanMouseDownStartSelect(event.InnerNode()) || IsLinkSelection(event)) &&
@@ skipping 312 matching lines @@
 
 bool IsExtendingSelection(const MouseEventWithHitTestResults& event) {
   bool is_mouse_down_on_link_or_image =
       event.IsOverLink() || event.GetHitTestResult().GetImage();
   return (event.Event().GetModifiers() & WebInputEvent::Modifiers::kShiftKey) !=
              0 &&
          !is_mouse_down_on_link_or_image;
 }
 
 }  // namespace blink