Selection Action mode triggered like a context menu

third_party/WebKit/Source/core/input/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 1792 matching lines @@
 }
 
 static bool ShouldShowContextMenuAtSelection(const FrameSelection& selection) {
   const VisibleSelection& visible_selection =
       selection.ComputeVisibleSelectionInDOMTreeDeprecated();
   if (!visible_selection.IsRange() && !visible_selection.RootEditableElement())
     return false;
   return selection.SelectionHasFocus();
 }
 
 WebInputEventResult EventHandler::SendContextMenuEventForKey(

[bokan, 2017/05/24 19:15:52]

This method should be renamed as it's not just for keyboard anymore (and hasn't
been prior to this I think). Perhaps ShowNonLocatedContextMenu?

     Element* override_target_element,
     WebMenuSourceType source_type) {
   FrameView* view = frame_->View();
   if (!view)
     return WebInputEventResult::kNotHandled;
 
   Document* doc = frame_->GetDocument();
   if (!doc)
     return WebInputEventResult::kNotHandled;
 
@@ skipping 51 matching lines @@
   if (!target_node)
     target_node = doc;
 
   // Use the focused node as the target for hover and active.
   HitTestRequest request(HitTestRequest::kActive);
   HitTestResult result(request, location_in_root_frame);
   result.SetInnerNode(target_node);
   doc->UpdateHoverActiveState(request, result.InnerElement());
 
   // The contextmenu event is a mouse event even when invoked using the
   // keyboard.  This is required for web compatibility.

[bokan, 2017/05/24 19:15:52]

keyboard or other methods.

   WebInputEvent::Type event_type = WebInputEvent::kMouseDown;
   if (frame_->GetSettings() &&
       frame_->GetSettings()->GetShowContextMenuOnMouseUp())
     event_type = WebInputEvent::kMouseUp;
 
+  WebInputEvent::Modifiers modifiers;
+  switch (source_type) {
+    case kMenuSourceTouch:
+    case kMenuSourceLongPress:
+    case kMenuSourceTouchHandle:
+      modifiers = WebInputEvent::kIsCompatibilityEventForTouch;
+      break;
+    default:
+      modifiers = WebInputEvent::kNoModifiers;
+      break;
+  }
+
   WebMouseEvent mouse_event(
       event_type,
       WebFloatPoint(location_in_root_frame.X(), location_in_root_frame.Y()),
       WebFloatPoint(global_position.X(), global_position.Y()),
-      WebPointerProperties::Button::kNoButton, /* clickCount */ 0,
-      ((source_type == kMenuSourceTouchHandle)
-           ? WebInputEvent::kIsCompatibilityEventForTouch
-           : WebInputEvent::kNoModifiers),
+      WebPointerProperties::Button::kNoButton, /* clickCount */ 0, modifiers,
       TimeTicks::Now().InSeconds());
 
   // TODO(dtapuska): Transition the mouseEvent to be created really in viewport
   // coordinates instead of root frame coordinates.
   mouse_event.SetFrameScale(1);
 
   return SendContextMenuEvent(mouse_event, override_target_element);
 }
 
+void EventHandler::SendContextMenuEventForTouchSelection(
+    WebMenuSourceType menu_source) {
+  // TODO(editing-dev): The use of UpdateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  frame_->GetDocument()->UpdateStyleAndLayoutIgnorePendingStylesheets();
+  FrameSelection& selection = frame_->Selection();
+  if (!selection.IsAvailable() || !selection.IsHandleVisible() ||

[bokan, 2017/05/24 19:15:52]

Do we need a new method here? Couldn't we just do this in the above method based
on menu_source?

+      selection.IsHidden())
+    return;
+  SendContextMenuEventForKey(nullptr, menu_source);
+}
+
 void EventHandler::ScheduleHoverStateUpdate() {
   // TODO(https://crbug.com/668758): Use a normal BeginFrame update for this.
   if (!hover_timer_.IsActive() &&
       !mouse_event_manager_->IsMousePositionUnknown())
     hover_timer_.StartOneShot(0, BLINK_FROM_HERE);
 }
 
 void EventHandler::ScheduleCursorUpdate() {
   // We only want one timer for the page, rather than each frame having it's own
   // timer competing which eachother (since there's only one mouse cursor).
@@ skipping 208 matching lines @@
     MouseEventWithHitTestResults& mev,
     LocalFrame* subframe) {
   WebInputEventResult result =
       subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
   if (result != WebInputEventResult::kNotHandled)
     return result;
   return WebInputEventResult::kHandledSystem;
 }
 
 }  // namespace blink