Selection Action mode triggered like a context menu

content/public/common/context_menu_params.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_
 #define CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/public/common/menu_item.h"
 #include "content/public/common/page_state.h"
 #include "third_party/WebKit/public/platform/WebCString.h"
 #include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
 #include "third_party/WebKit/public/web/WebContextMenuData.h"
 #include "ui/base/ui_base_types.h"
 #include "url/gurl.h"
 
 #if defined(OS_ANDROID)
 #include "ui/gfx/geometry/point.h"
+#include "ui/gfx/geometry/rect.h"
 #endif
 
 namespace content {
 
 struct CONTENT_EXPORT CustomContextMenuContext {
   static const int32_t kCurrentRenderWidget;
 
   CustomContextMenuContext();
 
   bool is_pepper_menu;
@@ skipping 115 matching lines @@
   std::vector<MenuItem> custom_items;
 
   ui::MenuSourceType source_type;
 
   // Extra properties for the context menu.
   std::map<std::string, std::string> properties;
 
 #if defined(OS_ANDROID)
   // Points representing the coordinates in the document space of the start and
   // end of the selection, if there is one.
   gfx::Point selection_start;

[aelias_OOO_until_Jul13, 2017/04/21 21:42:19]

What about this?  Looks redundant with selection_rect.  I think it's fine for
selection_rect to be cross-platform instead of Android-specific, so can this be
deleted?

   gfx::Point selection_end;
 #endif
 
   // If this node is an input field, the type of that field.
   blink::WebContextMenuData::InputFieldType input_field_type;
+
+  gfx::Rect selection_rect;

[boliu, 2017/04/21 21:20:19]

comment explaining this, what coordinate space is this in, etc.

should this be in the OS_ANDROID block that also contains selection_start/end?
Actually what's the relationship between this and the selection points?

+
+  bool from_touch;

[boliu, 2017/04/21 21:20:19]

how is from_touch different from the two source types used in
ContentViewCoreImpl::ShowSelectionMenu?

 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_