Selection Action mode triggered like a context menu

content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ClipboardManager;
@@ skipping 98 matching lines @@
     private String mLastSelectedText;
 
     // Tracks whether a selection is currently active.  When applied to selected text, indicates
     // whether the last selected text is still highlighted.
     private boolean mHasSelection;
 
     // Lazily created paste popup menu, triggered either via long press in an
     // editable region or from tapping the insertion handle.
     private PastePopupMenu mPastePopupMenu;
     private boolean mWasPastePopupShowingOnInsertionDragStart;
+    private boolean mSelectionHandleDragStopped;

[aelias_OOO_until_Jul13, 2017/04/21 21:42:19]

I think it would be clearer to invert this, "mDraggingSelectionHandle"

 
     // The client that processes textual selection, or null if none exists.
     private SelectionClient mSelectionClient;
 
     // The classificaton result of the selected text if the selection exists and
     // ContextSelectionProvider was able to classify it, otherwise null.
     private ContextSelectionProvider.Result mClassificationResult;
 
     // The resource ID for Assist menu item.
     private int mAssistMenuItemId;
@@ skipping 72 matching lines @@
     // True if action mode is initialized to a working (not a no-op) mode.
     private boolean isActionModeSupported() {
         return mCallback != EMPTY_CALLBACK;
     }
 
     @Override
     public void setAllowedMenuItems(int allowedMenuItems) {
         mAllowedMenuItems = allowedMenuItems;
     }
 
+    public void showSelectionMenu(int xAnchor, int yAnchor, int left, int top, int right,
+            int bottom, boolean isEditable, boolean isPasswordType, String selectionText,
+            boolean canSelectAll) {
+        mSelectionRect.set(left, top, right, bottom);
+        mEditable = isEditable;
+        mLastSelectedText = selectionText;
+        mIsPasswordType = isPasswordType;
+        mHasSelection = selectionText.length() != 0;

[aelias_OOO_until_Jul13, 2017/04/21 21:42:19]

This state is redundant now, can be replaced by bool hasSelection() { return
mLastSelectedText.length() != 0; }  (different behavior with
onSelectionChanged() but that seems like probably a fix?).

+        mIsInsertion = selectionText.length() == 0;

[aelias_OOO_until_Jul13, 2017/04/21 21:42:19]

Likewise for mIsInsertion maybe?  Is there any value-added to setting it in
INSERTION_HANDLE_SHOWN?

+        mCanSelectAllForPastePopup = canSelectAll;
+        mUnselectAllOnDismiss = true;
+        if (isInsertion()) {
+            createAndShowPastePopup(xAnchor, yAnchor);
+        } else {
+            if (mSelectionClient == null
+                    || !mSelectionClient.sendsSelectionPopupUpdates(!mSelectionHandleDragStopped)) {
+                showActionModeOrClearOnFailure();
+            } else {
+                // Rely on |mSelectionClient| sending a classification request and the request
+                // always calling onClassified() callback.
+                mPendingShowActionMode = true;
+            }
+            mSelectionHandleDragStopped = false;
+        }
+    }
+
     /**
      * Show (activate) android action mode by starting it.
      *
      * <p>Action mode in floating mode is tried first, and then falls back to
      * a normal one.
      * <p> If the action mode cannot be created the selection is cleared.
      */
     public void showActionModeOrClearOnFailure() {
         mPendingShowActionMode = false;
 
@@ skipping 25 matching lines @@
         if (!isActionModeValid()) clearSelection();
     }
 
     @TargetApi(Build.VERSION_CODES.M)
     private ActionMode startFloatingActionMode() {
         ActionMode actionMode = mView.startActionMode(
                 new FloatingActionModeCallback(this, mCallback), ActionMode.TYPE_FLOATING);
         return actionMode;
     }
 
-    void createAndShowPastePopup(int x, int y, boolean canSelectAll) {
+    void createAndShowPastePopup(int x, int y) {
         if (mView.getParent() == null || mView.getVisibility() != View.VISIBLE) {
             return;
         }
 
         if (!supportsFloatingActionMode() && !canPaste()) return;
         destroyPastePopup();
-        mCanSelectAllForPastePopup = canSelectAll;
         PastePopupMenuDelegate delegate = new PastePopupMenuDelegate() {
             @Override
             public void paste() {
                 mWebContents.paste();
                 mWebContents.dismissTextHandles();
             }
 
             @Override
             public boolean canPaste() {
                 return SelectionPopupController.this.canPaste();
@@ skipping 364 matching lines @@
         }
     }
 
     /**
      * Perform a select all action.
      */
     @VisibleForTesting
     void selectAll() {
         mWebContents.selectAll();
         mClassificationResult = null;
-        if (needsActionMenuUpdate()) showActionModeOrClearOnFailure();
-
         // Even though the above statement logged a SelectAll user action, we want to
         // track whether the focus was in an editable field, so log that too.
         if (isSelectionEditable()) {
             RecordUserAction.record("MobileActionMode.SelectAllWasEditable");
         } else {
             RecordUserAction.record("MobileActionMode.SelectAllWasNonEditable");
         }
     }
 
     /**
@@ skipping 174 matching lines @@
     // All coordinates are in DIP.
     void onSelectionEvent(int eventType, int xAnchor, int yAnchor,
             int left, int top, int right, int bottom, boolean isScrollInProgress,
             boolean touchScrollInProgress) {
         // Ensure the provided selection coordinates form a non-empty rect, as required by
         // the selection action mode.
         if (left == right) ++right;
         if (top == bottom) ++bottom;
         switch (eventType) {
             case SelectionEventType.SELECTION_HANDLES_SHOWN:
-                mSelectionRect.set(left, top, right, bottom);
-                mHasSelection = true;
-                mUnselectAllOnDismiss = true;
-                if (mSelectionClient == null || !mSelectionClient.sendsSelectionPopupUpdates()) {
-                    showActionModeOrClearOnFailure();
-                } else {
-                    // Rely on |mSelectionClient| sending a classification request and the request
-                    // always calling onClassified() callback.
-                    mPendingShowActionMode = true;
-                }
                 break;
 
             case SelectionEventType.SELECTION_HANDLES_MOVED:
                 mSelectionRect.set(left, top, right, bottom);
                 if (mPendingShowActionMode) {
                     showActionModeOrClearOnFailure();
                 } else {
                     invalidateContentRect();
                 }
                 break;
 
             case SelectionEventType.SELECTION_HANDLES_CLEARED:
                 mHasSelection = false;
                 mUnselectAllOnDismiss = false;
                 mSelectionRect.setEmpty();
                 finishActionMode();
                 break;
 
             case SelectionEventType.SELECTION_HANDLE_DRAG_STARTED:
+                mSelectionHandleDragStopped = false;
                 hideActionMode(true);
                 break;
 
             case SelectionEventType.SELECTION_HANDLE_DRAG_STOPPED:
-                if (mSelectionClient == null || !mSelectionClient.sendsSelectionPopupUpdates()) {
-                    hideActionMode(false);
-                }
-                // Otherwise rely on |mSelectionClient| sending a classification request and the
-                // request always calling onClassified() callback.
+                mSelectionHandleDragStopped = true;
+                mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_SHOWN:
                 mSelectionRect.set(left, top, right, bottom);
                 mIsInsertion = true;
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_MOVED:
                 mSelectionRect.set(left, top, right, bottom);
                 if (!isScrollInProgress && isPastePopupShowing()) {
@@ skipping 144 matching lines @@
 
                 // Remain pending until SELECTION_HANDLES_MOVED arrives.
                 if (mPendingShowActionMode) return;
             }
 
             // Rely on this method to clear |mHidden| and unhide the action mode.
             showActionModeOrClearOnFailure();
         }
     };
 }