Selection Action mode triggered like a context menu

content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.support.annotation.IntDef;
 import android.text.TextUtils;
 
 import org.chromium.base.annotations.CalledByNative;
@@ skipping 61 matching lines @@
         mProvider.cancelAllRequests();
     }
 
     // SelectionClient implementation
     @Override
     public void onSelectionChanged(String selection) {}
 
     @Override
     public void onSelectionEvent(int eventType, float posXPix, float posYPix) {
         switch (eventType) {
-            case SelectionEventType.SELECTION_HANDLES_SHOWN:
-                // This event is sent when the long press is detected which causes
-                // selection to appear for the first time. Temporarily hiding the
-                // handles that happens e.g. during scroll does not affect this event.
-                requestSurroundingText(SUGGEST_AND_CLASSIFY);
-                break;
-
             case SelectionEventType.SELECTION_HANDLES_CLEARED:
                 // The ActionMode should be stopped when this event comes.
                 cancelAllRequests();
                 break;
 
-            case SelectionEventType.SELECTION_HANDLE_DRAG_STOPPED:
-                // This event is sent after a user stopped dragging one of the
-                // selection handles, i.e. stopped modifying the selection.
-                requestSurroundingText(CLASSIFY);
-                break;
-
             default:
                 break; // ignore
         }
     }
 
     @Override
     public void showUnhandledTapUIIfNeeded(int x, int y) {}
 
     @Override
-    public boolean sendsSelectionPopupUpdates() {
+    public boolean sendsSelectionPopupUpdates(boolean shouldSuggest) {
+        requestSurroundingText(shouldSuggest ? SUGGEST_AND_CLASSIFY : CLASSIFY);

[boliu, 2017/04/21 21:20:18]

this method right now is "does this client send selection updates", not "do
selection updates"

Probably should just reword the method. Maybe also make cancel explicit

         return true;
     }
 
     private void cancelAllRequests() {
         if (mNativeContextSelectionClient != 0) {
             nativeCancelAllRequests(mNativeContextSelectionClient);
         }
 
         mProvider.cancelAllRequests();
     }
@@ skipping 28 matching lines @@
                 assert false : "Unexpected callback data";
                 break;
         }
     }
 
     private native long nativeInit(WebContents webContents);
     private native void nativeRequestSurroundingText(
             long nativeContextSelectionClient, int numExtraCharacters, int callbackData);
     private native void nativeCancelAllRequests(long nativeContextSelectionClient);
 }