sandbox/linux/seccomp-bpf/verifier.cc - Issue 278583005: Linux Sandbox: Add support for SECCOMP_RET_TRACE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf/verifier.cc

Issue 278583005: Linux Sandbox: Add support for SECCOMP_RET_TRACE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/seccomp-bpf/verifier.cc

diff --git a/sandbox/linux/seccomp-bpf/verifier.cc b/sandbox/linux/seccomp-bpf/verifier.cc

index 1292504decc012e9cfbc6c3e6eca39cc440b8cf6..0d422012e1aaf91bd04d4d55b1c0d030b1064766 100644

--- a/sandbox/linux/seccomp-bpf/verifier.cc

+++ b/sandbox/linux/seccomp-bpf/verifier.cc

@@ -421,10 +421,10 @@ uint32_t Verifier::EvaluateBPF(const std::vector<struct sock_filter>& program,

switch (r & SECCOMP_RET_ACTION) {

case SECCOMP_RET_TRAP:

case SECCOMP_RET_ERRNO:

+ case SECCOMP_RET_TRACE:

case SECCOMP_RET_ALLOW:

break;

case SECCOMP_RET_KILL: // We don't ever generate this

- case SECCOMP_RET_TRACE: // We don't ever generate this

case SECCOMP_RET_INVALID: // Should never show up in BPF program

default:

*err = "Unexpected return code found in BPF program";