Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 278583002: LeakExpectations: Add callstack-placards-discarded.html and some tests which time out (Closed)

Created:
6 years, 7 months ago by hajimehoshi
Modified:
6 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews
Visibility:
Public.

Description

LeakExpectations: Add callstack-placards-discarded.html and some tests which time out BUG=371264 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173610

Patch Set 1 #

Total comments: 5

Patch Set 2 : kouhei's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M LayoutTests/LeakExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hajimehoshi
Please rubber stamp this.
6 years, 7 months ago (2014-05-08 07:07:33 UTC) #1
kouhei (in TOK)
https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations File LayoutTests/LeakExpectations (right): https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations#newcode28 LayoutTests/LeakExpectations:28: after here. https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations#newcode179 LayoutTests/LeakExpectations:179: crbug.com/371264 virtual/implsidepainting/inspector/timeline/timeline-window-filter.html [ Timeout ] ...
6 years, 7 months ago (2014-05-08 07:14:06 UTC) #2
hajimehoshi
https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations File LayoutTests/LeakExpectations (right): https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations#newcode179 LayoutTests/LeakExpectations:179: crbug.com/371264 virtual/implsidepainting/inspector/timeline/timeline-window-filter.html [ Timeout ] On 2014/05/08 07:14:06, kouhei ...
6 years, 7 months ago (2014-05-08 07:17:39 UTC) #3
kouhei (in TOK)
https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations File LayoutTests/LeakExpectations (right): https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations#newcode179 LayoutTests/LeakExpectations:179: crbug.com/371264 virtual/implsidepainting/inspector/timeline/timeline-window-filter.html [ Timeout ] On 2014/05/08 07:17:40, hajimehoshi ...
6 years, 7 months ago (2014-05-08 07:18:12 UTC) #4
hajimehoshi
Thanks! https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations File LayoutTests/LeakExpectations (right): https://codereview.chromium.org/278583002/diff/1/LayoutTests/LeakExpectations#newcode179 LayoutTests/LeakExpectations:179: crbug.com/371264 virtual/implsidepainting/inspector/timeline/timeline-window-filter.html [ Timeout ] On 2014/05/08 07:18:13, ...
6 years, 7 months ago (2014-05-08 07:21:37 UTC) #5
kouhei (in TOK)
lgtm
6 years, 7 months ago (2014-05-08 07:23:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/278583002/20001
6 years, 7 months ago (2014-05-08 07:24:30 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 07:24:54 UTC) #8
Message was sent while issue was closed.
Change committed as 173610

Powered by Google App Engine
This is Rietveld 408576698