arc: Provide UMA for OptIn flow.

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 284 matching lines @@
   // MaybeReenableArc() directly.
   void MaybeStartArcDataRemoval();
   void OnArcDataRemoved(bool success);
 
   // On ARC session stopped and/or data removal completion, this is called
   // so that, if necessary, ARC session is restarted.
   // TODO(hidehiko): This can be removed after the racy state machine
   // is fixed.
   void MaybeReenableArc();
 
+  // Starts tracking of OptIn flow. Tracked flows are reported to UMA.
+  void StartOptInFlowTracking();

[Luis Héctor Chávez, 2017/03/30 15:49:25]

Can we abstract this logic to stop giving too much responsibility to this class?

class ScopedOptInFlowTracker {
 public:
  ScopedOptInFlowTracker() { /* ... */ };
  ~ScopedOptInFlowTracker() { /* ... */ }
  TrackRetry() { retried_ = true; }
  TrackSuccess() { success_ = true; }
 private:
  bool retried_ = false;
  bool success_ = false;
}

then replace calls to StartOptInFlowTracking with scoped_opt_in_tracker_ =
base::MakeUnique<...>();

and StopOptInFlowTracking with scoped_opt_in_tracker_.reset();

[khmel, 2017/03/30 17:01:43]

That nice, thanks

+
+  // Stop tracking of OptIn flow. |succeeded| indicates that flow finished
+  // successfully.
+  void StopOptInFlowTracking(bool succeeded);
+
   std::unique_ptr<ArcSessionRunner> arc_session_runner_;
 
   // Unowned pointer. Keeps current profile.
   Profile* profile_ = nullptr;
 
   // Whether ArcSessionManager is requested to enable (starting to run ARC
   // instance) or not.
   bool enable_requested_ = false;
 
   // Internal state machine. See also State enum class.
   State state_ = State::NOT_INITIALIZED;
   base::ObserverList<Observer> observer_list_;
   std::unique_ptr<ArcAppLauncher> playstore_launcher_;
   bool reenable_arc_ = false;
   bool provisioning_reported_ = false;
+  bool optin_flow_tracked_ = false;
+  bool optin_flow_error_detected_ = false;
   base::OneShotTimer arc_sign_in_timer_;
 
   std::unique_ptr<ArcSupportHost> support_host_;
 
   std::unique_ptr<ArcTermsOfServiceNegotiator> terms_of_service_negotiator_;
 
   std::unique_ptr<ArcAuthContext> context_;
   std::unique_ptr<ArcAndroidManagementChecker> android_management_checker_;
 
   // The time when the sign in process started.
   base::Time sign_in_start_time_;
   // The time when ARC was about to start.
   base::Time arc_start_time_;
   base::Closure attempt_user_exit_callback_;
 
   // Must be the last member.
   base::WeakPtrFactory<ArcSessionManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_