arc: Provide UMA for OptIn flow.

chrome/browser/chromeos/arc/arc_optin_uma.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_OPTIN_UMA_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_OPTIN_UMA_H_
 
 #include <ostream>
 
 #include "components/arc/common/auth.mojom.h"
@@ skipping 10 matching lines @@
   OPTED_OUT = 0,               // ARC was opted out by user.
   OPTED_IN = 1,                // ARC was opted in by user.
   NOTIFICATION_ACCEPTED = 2,   // ARC OptIn notification was accepted.
   NOTIFICATION_DECLINED = 3,   // ARC OptIn notification was declined.
   NOTIFICATION_TIMED_OUT = 4,  // ARC OptIn notification was timed out.
   RETRY = 5,                   // User asked to retry OptIn.
   SIZE,                        // The size of this enum; keep last.
 };
 
 enum class OptInCancelReason {
-  USER_CANCEL = 0,          // Canceled by user.
-  UNKNOWN_ERROR = 1,        // Unclassified failure.
-  NETWORK_ERROR = 2,        // Network failure.
-  SERVICE_UNAVAILABLE = 3,  // GMS Services are not available.
+  // Canceled by user.

[Luis Héctor Chávez, 2017/03/30 15:49:25]

The formatting for this enum looks different from the one in OptInFlowResult.
And different from OptInActionType too. Please stick to one.

[khmel, 2017/03/30 17:01:43]

Done.

+  USER_CANCEL = 0,
+  // Unclassified failure.
+  UNKNOWN_ERROR = 1,
+  // Network failure.
+  NETWORK_ERROR = 2,
+  DEPRECATED_SERVICE_UNAVAILABLE = 3,
   DEPRECATED_BAD_AUTHENTICATION = 4,
   DEPRECATED_GMS_CORE_NOT_AVAILABLE = 5,
-  CLOUD_PROVISION_FLOW_FAIL = 6,    // Cloud provision flow failed.
-  ANDROID_MANAGEMENT_REQUIRED = 7,  // Android management is required for user.
-  SIZE,                             // The size of this enum; keep last.
+  // Cloud provision flow failed.
+  CLOUD_PROVISION_FLOW_FAIL = 6,
+  // Android management is required for user.
+  ANDROID_MANAGEMENT_REQUIRED = 7,
+  // Cannot start ARC because it is busy.
+  SESSION_BUSY = 8,
+  // The size of this enum; keep last.
+  SIZE,
 };
 
 enum class OptInSilentAuthCode {
   // Silent auth code feature is disabled.
   DISABLED = 0,
   // Silent auth code fetched normally.
   SUCCESS = 1,
   // HTTP Context cannot be prepared.
   CONTEXT_NOT_READY = 2,
   // No LST token is available.
@@ skipping 64 matching lines @@
   // Network connection is unavailable in ARC.
   NO_NETWORK_CONNECTION = 19,
 
   // ARC is not enabled.
   ARC_DISABLED = 20,
 
   // The size of this enum; keep last.
   SIZE,
 };
 
+enum class OptInFlowResult : int {
+  // OptIn has been started.

[Luis Héctor Chávez, 2017/03/30 15:49:25]

nit: s/has been/has/

[khmel, 2017/03/30 17:01:43]

Done.

+  STARTED = 0,
+
+  // OptIn has been succeeded, this also includes succeeded with error cases.
+  SUCCEEDED = 1,
+
+  // OptIn has been succeeded but with retry after an error.
+  SUCCEEDED_AFTER_RETRY = 2,
+
+  // OptIn has been canceled, this also includes canceled after error cases.
+  CANCELED = 3,
+
+  // OptIn has been canceled after an error was reported.
+  CANCELED_AFTER_ERROR = 4,
+
+  // The size of this enum; keep last.
+  SIZE,
+};
+
 void UpdateOptInActionUMA(OptInActionType type);
 void UpdateOptInCancelUMA(OptInCancelReason reason);
+void UpdateOptInFlowResultUMA(OptInFlowResult result);
 void UpdateEnabledStateUMA(bool enabled);
 void UpdateProvisioningResultUMA(ProvisioningResult result, bool managed);
 void UpdateProvisioningTiming(const base::TimeDelta& elapsed_time,
                               bool success,
                               bool managed);
 void UpdateSilentAuthCodeUMA(OptInSilentAuthCode state);
 void UpdateAuthTiming(const char* histogram_name, base::TimeDelta elapsed_time);
 void UpdateAuthCheckinAttempts(int32_t num_attempts);
 void UpdateAuthAccountCheckStatus(mojom::AccountCheckStatus status);
 
 // Outputs the stringified |result| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os, const ProvisioningResult& result);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_OPTIN_UMA_H_