chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 2785753003: Exclude building signin view controller and its delegate on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2785753003: Exclude building signin view controller and its delegate on ChromeOS (Closed)

Patch Set: Exclude SigninViewController on ChromeOS Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 2991e80ab6535094deb95aa54984a6c72c13f3b9..28385803e1e46aa7ac96b1efd627a46b32ab5f55 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -811,7 +811,8 @@ void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

&tutorial_mode);

if (SigninViewController::ShouldShowModalSigninForMode(bubble_view_mode)) {

- browser_->ShowModalSigninWindow(bubble_view_mode, access_point);

+ browser_->signin_view_controller()->ShowModalSignin(bubble_view_mode,

+ browser_, access_point);

} else {

AvatarBaseController* controller = [controller_ avatarButtonController];

NSView* anchor = [controller buttonView];