Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2785753003: Exclude building signin view controller and its delegate on ChromeOS (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 18df05fd5aa23a63b7e9920f1fe56b0ac42538f7..d551b2fb7ae1053c448d3ef70db87f4c84bbbf61 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -815,10 +815,7 @@ split_static_library("ui") {
"settings_window_manager.cc",
"settings_window_manager.h",
"settings_window_manager_observer.h",
- "signin_view_controller.cc",
"signin_view_controller.h",
- "signin_view_controller_delegate.cc",
- "signin_view_controller_delegate.h",
"singleton_tabs.cc",
"singleton_tabs.h",
"startup/automation_infobar_delegate.cc",
@@ -1254,6 +1251,7 @@ split_static_library("ui") {
"extensions/extension_installed_notification.h",
"input_method/input_method_engine_base.cc",
"input_method/input_method_engine_base.h",
+ "signin_view_controller_chromeos.cc",
"views/apps/chrome_native_app_window_views_aura_ash.cc",
"views/apps/chrome_native_app_window_views_aura_ash.h",
"views/intent_picker_bubble_view.cc",
@@ -1830,8 +1828,6 @@ split_static_library("ui") {
"views/process_singleton_dialog_linux.cc",
"views/profiles/profile_indicator_icon.cc",
"views/profiles/profile_indicator_icon.h",
- "views/profiles/signin_view_controller_delegate_views.cc",
- "views/profiles/signin_view_controller_delegate_views.h",
"views/profiles/user_manager_view.cc",
"views/profiles/user_manager_view.h",
"views/proximity_auth/proximity_auth_error_bubble_view.cc",
@@ -1937,6 +1933,13 @@ split_static_library("ui") {
deps += [ "//ui/views/mus" ]
}
+
+ if (!is_chromeos) {
+ sources += [
+ "views/profiles/signin_view_controller_delegate_views.cc",
+ "views/profiles/signin_view_controller_delegate_views.h",
+ ]
+ }
}
if (use_ash) {
sources += [
@@ -1978,6 +1981,9 @@ split_static_library("ui") {
"avatar_button_error_controller_delegate.h",
"external_protocol_dialog_delegate.cc",
"external_protocol_dialog_delegate.h",
+ "signin_view_controller.cc",
+ "signin_view_controller_delegate.cc",
+ "signin_view_controller_delegate.h",
"startup/default_browser_infobar_delegate.cc",
"startup/default_browser_infobar_delegate.h",
"startup/default_browser_prompt.cc",
« no previous file with comments | « no previous file | chrome/browser/ui/signin_view_controller.h » ('j') | chrome/browser/ui/signin_view_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698