Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view.cc

Issue 2785683003: views: implement width snapping for DialogDelegateViews (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
index 9694f755968124bc84f661b7a873ac8ec347eab6..14560657527f7fb48c3275473620c6b8279b9bf8 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
@@ -75,13 +75,7 @@ views::ClientView* ChooserDialogView::CreateClientView(views::Widget* widget) {
views::DialogClientView* client =
new views::DialogClientView(widget, GetContentsView());
- constexpr int kMinWidth = 402;
- constexpr int kMinHeight = 320;
- int min_width = LayoutDelegate::Get()->GetDialogPreferredWidth(
- LayoutDelegate::DialogWidth::MEDIUM);
- if (!min_width)
- min_width = kMinWidth;
- client->set_minimum_size(gfx::Size(min_width, kMinHeight));
+ client->set_minimum_size(gfx::Size(402, 320));
Peter Kasting 2017/03/30 00:35:35 I think this line may not be needed at all. If it
LayoutDelegate* delegate = LayoutDelegate::Get();
client->set_button_row_insets(gfx::Insets(

Powered by Google App Engine
This is Rietveld 408576698