views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/translate/translate_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 223 matching lines @@
       if (accelerator.key_code() == ui::VKEY_RETURN) {
         HandleButtonPressed(BUTTON_ID_DONE);
         return true;
       }
       break;
     }
   }
   return BubbleDialogDelegateView::AcceleratorPressed(accelerator);
 }
 
-gfx::Size TranslateBubbleView::GetPreferredSize() const {
+gfx::Size TranslateBubbleView::GetUnsnappedPreferredSize() const {
   int width = 0;

[Peter Kasting, 2017/03/30 00:35:36]

Isn't this the case you said could just be eliminated since it should be handled
by the layout manager?

   for (int i = 0; i < child_count(); i++) {
     const views::View* child = child_at(i);
     width = std::max(width, child->GetPreferredSize().width());
   }
   int height = GetCurrentView()->GetPreferredSize().height();
   return gfx::Size(width, height);
 }
 
 void TranslateBubbleView::OnPerformAction(views::Combobox* combobox) {
   HandleComboboxPerformAction(static_cast<ComboboxID>(combobox->id()));
@@ skipping 685 matching lines @@
   base::string16 label;
   if (model_->IsPageTranslatedInCurrentLanguages())
     label = l10n_util::GetStringUTF16(IDS_DONE);
   else
     label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT);
   advanced_done_button_->SetText(label);
   advanced_done_button_->SizeToPreferredSize();
   if (advanced_view_)
     advanced_view_->Layout();
 }