views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/extensions/chooser_dialog_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/chooser_controller/chooser_controller.h"
 #include "chrome/browser/extensions/api/chrome_device_permissions_prompt.h"
@@ skipping 57 matching lines @@
 }
 
 views::View* ChooserDialogView::CreateFootnoteView() {
   return device_chooser_content_view_->footnote_link();
 }
 
 views::ClientView* ChooserDialogView::CreateClientView(views::Widget* widget) {
   views::DialogClientView* client =
       new views::DialogClientView(widget, GetContentsView());
 
-  constexpr int kMinWidth = 402;
-  constexpr int kMinHeight = 320;
-  int min_width = LayoutDelegate::Get()->GetDialogPreferredWidth(
-      LayoutDelegate::DialogWidth::MEDIUM);
-  if (!min_width)
-    min_width = kMinWidth;
-  client->set_minimum_size(gfx::Size(min_width, kMinHeight));
+  client->set_minimum_size(gfx::Size(402, 320));

[Peter Kasting, 2017/03/30 00:35:35]

I think this line may not be needed at all.  If it's needed, we should
understand why, and where it should live, and in any case the size here
shouldn't be copy-and-pasted from DeviceChooserContentView (e.g. it should just
obtain the desired size from that class).  Another case where the TODO can
reference bug 610430.

 
   LayoutDelegate* delegate = LayoutDelegate::Get();
   client->set_button_row_insets(gfx::Insets(
       delegate->GetMetric(
           LayoutDelegate::Metric::UNRELATED_CONTROL_VERTICAL_SPACING),
       0, 0, 0));
   return client;
 }
 
 views::NonClientFrameView* ChooserDialogView::CreateNonClientFrameView(
@@ skipping 58 matching lines @@
 void ChromeDevicePermissionsPrompt::ShowDialogViews() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   std::unique_ptr<ChooserController> chooser_controller(
       new DevicePermissionsDialogController(web_contents()->GetMainFrame(),
                                             prompt()));
 
   constrained_window::ShowWebModalDialogViews(
       new ChooserDialogView(std::move(chooser_controller)), web_contents());
 }