views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/device_chooser_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/device_chooser_content_view.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_conversions.h"
 #include "chrome/app/vector_icons/vector_icons.h"
 #include "chrome/browser/ui/views/harmony/layout_delegate.h"
@@ skipping 94 matching lines @@
   // the throbber won't be shown at the same time.
   turn_adapter_off_help_->SetPosition(
       gfx::Point((rect.width() - turn_adapter_off_help_->width()) / 2,
                  (rect.height() - turn_adapter_off_help_->height()) / 2));
   turn_adapter_off_help_->SizeToFit(rect.width() -
                                     2 * kAdapterOffHelpLinkPadding);
   views::View::Layout();
 }
 
 gfx::Size DeviceChooserContentView::GetPreferredSize() const {
-  constexpr int kHeight = 320;
-  constexpr int kDefaultWidth = 402;
-  int width = LayoutDelegate::Get()->GetDialogPreferredWidth(
-      LayoutDelegate::DialogWidth::MEDIUM);
-  if (!width)
-    width = kDefaultWidth;
-  return gfx::Size(width, kHeight);
+  return gfx::Size(402, 320);

[Peter Kasting, 2017/03/30 00:35:34]

This width/height should probably be based on the font rather than exact pixel
values (i.e. be a localized contents size).  The TODO for this can reference bug
610430.

 }
 
 int DeviceChooserContentView::RowCount() {
   // When there are no devices, the table contains a message saying there
   // are no devices, so the number of rows is always at least 1.
   return std::max(base::checked_cast<int>(chooser_controller_->NumOptions()),
                   1);
 }
 
 base::string16 DeviceChooserContentView::GetText(int row, int column_id) {
@@ skipping 193 matching lines @@
 }
 
 void DeviceChooserContentView::SetGetHelpAndReScanLink() {
   DCHECK(footnote_link_);
   footnote_link_->SetText(help_and_re_scan_text_);
   footnote_link_->AddStyleRange(
       help_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
   footnote_link_->AddStyleRange(
       re_scan_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
 }