views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/create_application_shortcut_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/create_application_shortcut_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <cmath>
 #include <utility>
@@ skipping 302 matching lines @@
     layout->AddView(menu_check_box_);
   }
 
   if (quick_launch_check_box_ != nullptr) {
     layout->AddPaddingRow(0, views::kRelatedControlSmallVerticalSpacing);
     layout->StartRow(0, kTableColumnSetId);
     layout->AddView(quick_launch_check_box_);
   }
 }
 
-gfx::Size CreateApplicationShortcutView::GetPreferredSize() const {
+gfx::Size CreateApplicationShortcutView::GetUnsnappedPreferredSize() const {
   // TODO(evanm): should this use IDS_CREATE_SHORTCUTS_DIALOG_WIDTH_CHARS?

[Peter Kasting, 2017/03/30 00:35:34]

Yes, or that should be removed, because it's unused currently.

But really this is another case where we should be computing the unsnapped width
in a more granular way.  There's no tracking bug in the spreadsheet for
Create[Url,Chrome]ApplicationShortcutView (which is this is parent of); I'd file
one, add it to the sheet, then add a note in that bug about this and a TODO here
referencing the bug.

   static const int kDialogWidth = 360;
   int height = GetLayoutManager()->GetPreferredHeightForWidth(this,
       kDialogWidth);

[Peter Kasting, 2017/03/30 00:35:34]

This is just GetHeightForWidth().

   return gfx::Size(kDialogWidth, height);
 }
 
 base::string16 CreateApplicationShortcutView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK)
     return l10n_util::GetStringUTF16(IDS_CREATE_SHORTCUTS_COMMIT);
   return views::DialogDelegateView::GetDialogButtonLabel(button);
 }
 
@@ skipping 199 matching lines @@
 bool CreateChromeApplicationShortcutView::Cancel() {
   if (!close_callback_.is_null())
     close_callback_.Run(false);
   return CreateApplicationShortcutView::Cancel();
 }
 
 void CreateChromeApplicationShortcutView::OnAppInfoLoaded(
     std::unique_ptr<web_app::ShortcutInfo> shortcut_info) {
   shortcut_info_ = std::move(shortcut_info);
 }