views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_editor_view.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 114 matching lines @@
       url_tf_->SelectAll(true);
       url_tf_->RequestFocus();
     }
     return false;
   }
   // Otherwise save changes and close the dialog box.
   ApplyEdits();
   return true;
 }
 
-gfx::Size BookmarkEditorView::GetPreferredSize() const {
+gfx::Size BookmarkEditorView::GetUnsnappedPreferredSize() const {
   if (!show_tree_)
     return views::View::GetPreferredSize();
 
   return gfx::Size(views::Widget::GetLocalizedContentsSize(
       IDS_EDITBOOKMARK_DIALOG_WIDTH_CHARS,
       IDS_EDITBOOKMARK_DIALOG_HEIGHT_LINES));

[Peter Kasting, 2017/03/30 00:35:34]

Hmm.  This isn't the right way to size this dialog -- if we have a localized
size at all, it should only apply to something like a treeview, not the
surrounding stuff.  And maybe not even that.

I suggest adding a note on
https://bugs.chromium.org/p/chromium/issues/detail?id=651652 that
BookmarkEditorView needs its sizing computed in a better way in the show_tree_
case, and then leaving a TODO in here referencing that.

 }
 
 void BookmarkEditorView::OnTreeViewSelectionChanged(
     views::TreeView* tree_view) {
 }
 
 bool BookmarkEditorView::CanEdit(views::TreeView* tree_view,
                                  ui::TreeModelNode* node) {
   // Only allow editting of children of the bookmark bar node and other node.
   EditorNode* bb_node = tree_model_->AsNode(node);
@@ skipping 524 matching lines @@
                              Profile* profile,
                              const BookmarkEditor::EditDetails& details,
                              BookmarkEditor::Configuration configuration) {
   DCHECK(profile);
   BookmarkEditorView* editor = new BookmarkEditorView(
       profile, details.parent_node, details, configuration);
   editor->Show(parent_window);
 }
 
 }  // namespace chrome