Issue 278563002: Add histograms to record document.execCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 278563002: Add histograms to record document.execCommand. (Closed)

Created:
6 years, 7 months ago by yoichio

Modified:
6 years, 7 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add histograms to record document.execCommand. Add a UMA histogram metrics counting commands when document.execCommand is called. Each histogram id corresponding to a command name is in EditorCommand.cpp: https://src.chromium.org/viewvc/blink?revision=165849 The new UMA is WebCore.Document.execCommand and the corresponding implementation is done: https://src.chromium.org/viewvc/blink?revision=172020&view=revision This CL rewrites the summary of WebCore.Editing.Commands and let WebCore.Document.execCommand use the original summary because we found that WebCore.Editing.Commands doesn't represent what we want to do as the original summary says. That's because the new UMA is needed. BUG=338241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269460

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	tools/metrics/histograms/histograms.xml	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/278563002/1

6 years, 7 months ago (2014-05-08 22:55:52 UTC) #4

Message was sent while issue was closed.

Change committed as 269460

Expand Messages | Collapse Messages