runtime/lib/errors_patch.dart - Issue 2785623004: Fix #14144 confusing error message misusing a callable object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/errors_patch.dart

Issue 2785623004: Fix #14144 confusing error message misusing a callable object (Closed)

Patch Set: Realized that doing .runtimeType == _Closure is unnecessary, doing 'is' now. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/errors_patch.dart

diff --git a/runtime/lib/errors_patch.dart b/runtime/lib/errors_patch.dart

index cf42b572f7c9a7904b0c590174835b36af7ade8b..f26d4d4e238feb6c54a9618a043040da2ff5bd8e 100644

--- a/runtime/lib/errors_patch.dart

+++ b/runtime/lib/errors_patch.dart

@@ -312,7 +312,7 @@ class NoSuchMethodError {

.writeln("The $type_str '$memberName' was called on null.");

}

} else {

- if (_receiver is Function) {

+ if (_receiver is _Closure) {

msg_buf.writeln("Closure call with mismatched arguments: "

"function '$memberName'");

} else if (_receiver is _Type && memberName == "call") {

« no previous file with comments | « no previous file | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »