Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: tests/language/vm/no_such_method_error_message_vm_test.dart

Issue 2785623004: Fix #14144 confusing error message misusing a callable object (Closed)
Patch Set: Realized that doing .runtimeType == _Closure is unnecessary, doing 'is' now. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/language/vm/no_such_method_error_message_callable_vm_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--optimization-counter-threshold=10 --no-use-osr --no-background-co mpilation 4 // VMOptions=--optimization-counter-threshold=10 --no-use-osr --no-background-co mpilation
5 5
6 import "package:expect/expect.dart"; 6 import "package:expect/expect.dart";
7 7
8 // Test error message with noSuchMethodError: non-existent names 8 // Test error message with noSuchMethodError: non-existent names
9 // should result in a message that reports the missing method. 9 // should result in a message that reports the missing method.
10 10
11 call_bar(x) => x.bar(); 11 call_bar(x) => x.bar();
12 12
13 testMessage() { 13 testMessage() {
14 try { 14 try {
15 call_bar(5); 15 call_bar(5);
16 } catch (e) { 16 } catch (e) {
17 Expect.isTrue(e.toString().indexOf("has no instance method 'bar'") != -1); 17 Expect.isTrue(e.toString().contains("has no instance method 'bar'"));
18 } 18 }
19 } 19 }
20 20
21
22 main() { 21 main() {
23 for (var i = 0; i < 20; i++) testMessage(); 22 for (var i = 0; i < 20; i++) testMessage();
24 } 23 }
25
OLDNEW
« no previous file with comments | « tests/language/vm/no_such_method_error_message_callable_vm_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698