Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: tests/language/vm/no_such_args_error_message_vm_test.dart

Issue 2785623004: Fix #14144 confusing error message misusing a callable object (Closed)
Patch Set: Remove the check to 'call' methods to report closures. Clearer this way. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--optimization-counter-threshold=10 --no-use-osr --no-background-co mpilation
5
6 import "package:expect/expect.dart";
7
8 // Test error message with misusing Functions and Closures: wrong args
9 // should result in a message that reports the missing method.
10
11 call_with_bar(x) => x("bar");
12
13 testClosureMessage() {
14 try {
15 call_with_bar(() {});
16 } catch (e) {
17 Expect.isTrue(e.toString().indexOf(
rmacnak 2017/03/31 16:36:39 string.indexOf(substring) != -1 => string.contain
18 "Tried calling: testClosureMessage.<anonymous closure>(\"bar\")") !=
19 -1);
20 }
21 }
22
23 noargs() {}
24
25 testFunctionMessage() {
26 try {
27 call_with_bar(noargs);
28 } catch (e) {
29 Expect.isTrue(e.toString().indexOf("Tried calling: noargs(\"bar\")") != -1);
rmacnak 2017/03/31 16:36:39 "
30 }
31 }
32
33 main() {
34 for (var i = 0; i < 20; i++) testClosureMessage();
35 for (var i = 0; i < 20; i++) testFunctionMessage();
36 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698