content/browser/renderer_host/compositor_impl_android.cc - Issue 2785533003: Animated scroll shouldn't consume unhandled scrolls for OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2785533003: Animated scroll shouldn't consume unhandled scrolls for OOPIFs. (Closed)

Patch Set: Address nits, add comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/compositor_impl_android.cc

diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc

index f572bb644c23f4ebc8b8936dd00c1de9de3a2b6f..efbd3eb813a31fef715895845bb8aa0070fd0431 100644

--- a/content/browser/renderer_host/compositor_impl_android.cc

+++ b/content/browser/renderer_host/compositor_impl_android.cc

@@ -451,6 +451,10 @@ CompositorImpl::~CompositorImpl() {

GetSurfaceManager()->InvalidateFrameSinkId(frame_sink_id_);

}

+bool CompositorImpl::IsForSubframe() {

+ return false;

ui::UIResourceProvider& CompositorImpl::GetUIResourceProvider() {

return *this;

}