content/browser/renderer_host/compositor_impl_android.h - Issue 2785533003: Animated scroll shouldn't consume unhandled scrolls for OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.h

Issue 2785533003: Animated scroll shouldn't consume unhandled scrolls for OOPIFs. (Closed)

Patch Set: Rebase to master@{#465268}. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/compositor_impl_android.h

diff --git a/content/browser/renderer_host/compositor_impl_android.h b/content/browser/renderer_host/compositor_impl_android.h

index 19160a8c84cfb7c71c838a0c51c5543e08264783..1ea8e1f1a5ff07f1eec75e42cd133e4f4af538c3 100644

--- a/content/browser/renderer_host/compositor_impl_android.h

+++ b/content/browser/renderer_host/compositor_impl_android.h

@@ -102,6 +102,8 @@ class CONTENT_EXPORT CompositorImpl

void DidReceiveCompositorFrameAck() override;

void DidCompletePageScaleAnimation() override {}

+ bool IsForSubframe() override;

Charlie Reis 2017/04/18 21:59:03 nit: No blank line before, since this is part of t

wjmaclean 2017/04/18 23:26:49 Done.

// LayerTreeHostSingleThreadClient implementation.

void DidSubmitCompositorFrame() override;

void DidLoseCompositorFrameSink() override;