Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 2785533003: Animated scroll shouldn't consume unhandled scrolls for OOPIFs. (Closed)
Patch Set: Fix Android compile. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index c6c682fa6e90c08649c1d8bf22a845ae0c4683ce..30d0b40c4a99f7281d28805b7995cb8d430d640c 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -296,12 +296,6 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,
// Notifies the RenderWidgetHost that the View was destroyed.
void ViewDestroyed();
- // Signals if this host has forwarded a GestureScrollBegin without yet having
- // forwarded a matching GestureScrollEnd/GestureFlingStart.
- bool is_in_touchscreen_gesture_scroll() const {
- return is_in_touchscreen_gesture_scroll_;
- }
-
#if defined(OS_MACOSX)
// Pause for a moment to wait for pending repaint or resize messages sent to
// the renderer to arrive. If pending resize messages are for an old window
@@ -358,6 +352,10 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,
const blink::WebMouseWheelEvent& wheel_event,
const ui::LatencyInfo& ui_latency); // Virtual for testing.
+ // Signals if this host has forwarded a GestureScrollBegin without yet having
+ // forwarded a matching GestureScrollEnd/GestureFlingStart.
+ bool is_in_gesture_scroll(blink::WebGestureDevice device) override;
bokan 2017/04/11 16:23:14 Touchscreen and Touchpad gesture event streams can
sahel 2017/04/12 15:40:22 This function is used only for wheel/touchpad scro
bokan 2017/04/12 19:15:10 I don't think that's true. Taking a quick look, it
sahel 2017/04/18 15:43:43 I think is_in_touchscreen_gesture_scroll() is call
+
// Enables/disables touch emulation using mouse event. See TouchEmulator.
void SetTouchEventEmulationEnabled(
bool enabled, ui::GestureProviderConfigType config_type);

Powered by Google App Engine
This is Rietveld 408576698