Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 278553002: Fix code dup in volume_manager_common.js. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Fix code dup in volume_manager_common.js. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -116 lines) Patch
M ui/file_manager/file_manager/common/js/volume_manager_common.js View 1 chunk +0 lines, -116 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kinaba
6 years, 7 months ago (2014-05-08 02:11:25 UTC) #1
mtomasz
WOW! This must have happened during crazy rebasing when files moved from chrome/browser/resources/file_manager to chrome/ui/file_manager. ...
6 years, 7 months ago (2014-05-08 02:50:53 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-08 02:57:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/278553002/1
6 years, 7 months ago (2014-05-08 03:00:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 14:20:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 18:39:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13543)
6 years, 7 months ago (2014-05-08 18:39:52 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-09 00:00:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/278553002/1
6 years, 7 months ago (2014-05-09 00:09:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 04:32:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 06:21:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14112)
6 years, 7 months ago (2014-05-09 06:21:41 UTC) #12
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-09 06:27:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/278553002/1
6 years, 7 months ago (2014-05-09 06:29:51 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:00:59 UTC) #15
Message was sent while issue was closed.
Change committed as 269479

Powered by Google App Engine
This is Rietveld 408576698