Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: content/browser/loader/resource_request_info_impl.cc

Issue 2785523002: Reduce/remove usage of BrowserThread in content/browser/loader. (Closed)
Patch Set: Fix unittests redness Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_request_info_impl.cc
diff --git a/content/browser/loader/resource_request_info_impl.cc b/content/browser/loader/resource_request_info_impl.cc
index 2f4ffd4f1139ac64d036e6e92f18eb8e8bc1caa2..edab51de7deead88ec6591f487d6dcbaf3c96126 100644
--- a/content/browser/loader/resource_request_info_impl.cc
+++ b/content/browser/loader/resource_request_info_impl.cc
@@ -6,11 +6,11 @@
#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/loader/global_routing_id.h"
+#include "content/browser/loader/loader_globals.h"
#include "content/browser/loader/resource_message_filter.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/net/url_request_service_worker_data.h"
#include "content/common/net/url_request_user_data.h"
-#include "content/public/browser/browser_thread.h"
#include "content/public/browser/global_request_id.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/process_type.h"
@@ -21,7 +21,9 @@ namespace content {
namespace {
WebContents* GetWebContentsFromFTNID(int frame_tree_node_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ DCHECK(LoaderGlobals::Get()
jam 2017/03/29 15:44:33 seems like any code that calls WebContents is by d
ananta 2017/03/29 19:41:04 This function needs to be moved. We can revisit. R
+ ->main_thread_task_runner()
+ ->BelongsToCurrentThread());
FrameTreeNode* frame_tree_node =
FrameTreeNode::GloballyFindByID(frame_tree_node_id);
if (!frame_tree_node)

Powered by Google App Engine
This is Rietveld 408576698