Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2785523002: Reduce/remove usage of BrowserThread in content/browser/loader. (Closed)
Patch Set: Remove stray include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index aff0952bcce9f98ca39facfada6f3eec34e52f44..5ebdf4c466026c966dbb4635952a7cf6a0ca659e 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -257,7 +257,9 @@ class TestFilterSpecifyingChild : public ResourceMessageFilter {
NULL,
NULL,
base::Bind(&TestFilterSpecifyingChild::GetContexts,
- base::Unretained(this))),
+ base::Unretained(this)),
+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
+ BrowserThread::GetTaskRunnerForThread(BrowserThread::IO)),
resource_context_(resource_context),
canceled_(false),
received_after_canceled_(0) {
@@ -848,7 +850,9 @@ class ResourceDispatcherHostTest : public testing::Test, public IPC::Sender {
ResourceDispatcherHostTest()
: thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
- host_(base::Bind(&DownloadResourceHandler::Create)),
+ host_(base::Bind(&DownloadResourceHandler::Create),
+ base::ThreadTaskRunnerHandle::Get(),
+ base::ThreadTaskRunnerHandle::Get()),
use_test_ssl_certificate_(false),
send_data_received_acks_(false),
auto_advance_(false) {
@@ -867,6 +871,8 @@ class ResourceDispatcherHostTest : public testing::Test, public IPC::Sender {
~ResourceDispatcherHostTest() override {
filter_->OnChannelClosing();
+ filter_ = nullptr;
+ web_contents_filter_ = nullptr;
}
// IPC::Sender implementation

Powered by Google App Engine
This is Rietveld 408576698