|
|
Chromium Code Reviews
DescriptionFix MaximizeModeWIndowManagerTest with jessie case.
BUG=705727
TEST=Ran bots. Ran on CrOS device.
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thakis@chromium.org changed reviewers: + sky@chromium.org, thakis@chromium.org
Description was changed from ========== WIP: Fix MaximizeModeWIndowManagerTest with jessie case. BUG=705727 TEST=Ran bots. Ran on CrOS device. ========== to ========== Fix MaximizeModeWIndowManagerTest with jessie case. BUG=705727 TEST=Ran bots. Ran on CrOS device. ==========
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Hm, guess I'm not an ash/ owner :-P On Tue, Mar 28, 2017 at 4:29 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/ > builders/chromium_presubmit/builds/396659) > > https://codereview.chromium.org/2785513002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/03/28 20:31:29, Nico wrote: > Hm, guess I'm not an ash/ owner :-P > > On Tue, Mar 28, 2017 at 4:29 PM, mailto:commit-bot@chromium.org via > http://codereview.chromium.org <mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote: > > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > http://build.chromium.org/p/tryserver.chromium.linux/ > > builders/chromium_presubmit/builds/396659) > > > > https://codereview.chromium.org/2785513002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. I landed the fix here https://codereview.chromium.org/2784603002/ . I also made WindowUserData deal with this a bit better too.
On 2017/03/28 20:43:05, sky wrote: > On 2017/03/28 20:31:29, Nico wrote: > > Hm, guess I'm not an ash/ owner :-P > > > > On Tue, Mar 28, 2017 at 4:29 PM, mailto:commit-bot@chromium.org via > > http://codereview.chromium.org > <mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote: > > > > > Try jobs failed on following builders: > > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/ > > > builders/chromium_presubmit/builds/396659) > > > > > > https://codereview.chromium.org/2785513002/ > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Chromium-reviews" group. > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org. > > I landed the fix here https://codereview.chromium.org/2784603002/ . I also made > WindowUserData deal with this a bit better too. Thank you. So closing this. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
