Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2785513002: Fix MaximizeModeWIndowManagerTest with jessie case. (Closed)

Created:
3 years, 8 months ago by hidehiko
Modified:
3 years, 8 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MaximizeModeWIndowManagerTest with jessie case. BUG=705727 TEST=Ran bots. Ran on CrOS device.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ash/wm/screen_pinning_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
3 years, 8 months ago (2017-03-28 20:17:54 UTC) #6
Nico
lgtm
3 years, 8 months ago (2017-03-28 20:18:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785513002/1
3 years, 8 months ago (2017-03-28 20:18:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/396659)
3 years, 8 months ago (2017-03-28 20:29:03 UTC) #12
Nico
Hm, guess I'm not an ash/ owner :-P On Tue, Mar 28, 2017 at 4:29 ...
3 years, 8 months ago (2017-03-28 20:31:29 UTC) #13
sky
On 2017/03/28 20:31:29, Nico wrote: > Hm, guess I'm not an ash/ owner :-P > ...
3 years, 8 months ago (2017-03-28 20:43:05 UTC) #14
hidehiko
3 years, 8 months ago (2017-03-29 04:50:58 UTC) #15
On 2017/03/28 20:43:05, sky wrote:
> On 2017/03/28 20:31:29, Nico wrote:
> > Hm, guess I'm not an ash/ owner :-P
> > 
> > On Tue, Mar 28, 2017 at 4:29 PM, mailto:commit-bot@chromium.org via
> > http://codereview.chromium.org
> <mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
> > 
> > > Try jobs failed on following builders:
> > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > > http://build.chromium.org/p/tryserver.chromium.linux/
> > > builders/chromium_presubmit/builds/396659)
> > >
> > > https://codereview.chromium.org/2785513002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> I landed the fix here https://codereview.chromium.org/2784603002/ . I also
made
> WindowUserData deal with this a bit better too.

Thank you. So closing this.

Powered by Google App Engine
This is Rietveld 408576698