Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2785493006: Ensure system UI mode stays set when in VR. (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure system UI mode stays set when in VR. The system UI mode can be set to incorrect values shortly after entering VR. This feels like a framework bug as I did my best to check that chrome code wasn't updating the system UI. In any case, we can solve this problem in general by listening for system UI mode changes. BUG=706430 Review-Url: https://codereview.chromium.org/2785493006 Cr-Commit-Position: refs/heads/master@{#460767} Committed: https://chromium.googlesource.com/chromium/src/+/f0259fbbf8cd5f94aab46c7a43ac2aac3d662754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 7 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mthiesse
PTAL
3 years, 8 months ago (2017-03-29 16:16:51 UTC) #2
bshe
On 2017/03/29 16:16:51, mthiesse wrote: > PTAL lgtm
3 years, 8 months ago (2017-03-30 00:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785493006/1
3 years, 8 months ago (2017-03-30 14:30:36 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 15:31:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0259fbbf8cd5f94aab46c7a43ac...

Powered by Google App Engine
This is Rietveld 408576698