Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: components/translate/core/browser/translate_manager.cc

Issue 2785493004: Integrate RankerModelLoader with TranslateRanker. (Closed)
Patch Set: fix bogus compile error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_manager.h" 5 #include "components/translate/core/browser/translate_manager.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 std::unique_ptr<TranslateManager::TranslateErrorCallbackList::Subscription> 124 std::unique_ptr<TranslateManager::TranslateErrorCallbackList::Subscription>
125 TranslateManager::RegisterTranslateErrorCallback( 125 TranslateManager::RegisterTranslateErrorCallback(
126 const TranslateManager::TranslateErrorCallback& callback) { 126 const TranslateManager::TranslateErrorCallback& callback) {
127 if (!g_callback_list_) 127 if (!g_callback_list_)
128 g_callback_list_ = new TranslateErrorCallbackList; 128 g_callback_list_ = new TranslateErrorCallbackList;
129 return g_callback_list_->Add(callback); 129 return g_callback_list_->Add(callback);
130 } 130 }
131 131
132 TranslateManager::TranslateManager( 132 TranslateManager::TranslateManager(
133 TranslateClient* translate_client, 133 TranslateClient* translate_client,
134 TranslateRanker* translate_ranker,
134 const std::string& accept_languages_pref_name) 135 const std::string& accept_languages_pref_name)
135 : page_seq_no_(0), 136 : page_seq_no_(0),
136 accept_languages_pref_name_(accept_languages_pref_name), 137 accept_languages_pref_name_(accept_languages_pref_name),
137 translate_client_(translate_client), 138 translate_client_(translate_client),
138 translate_driver_(translate_client_->GetTranslateDriver()), 139 translate_driver_(translate_client_->GetTranslateDriver()),
140 translate_ranker_(translate_ranker),
139 language_state_(translate_driver_), 141 language_state_(translate_driver_),
140 translate_event_(base::MakeUnique<metrics::TranslateEventProto>()), 142 translate_event_(base::MakeUnique<metrics::TranslateEventProto>()),
141 weak_method_factory_(this) { 143 weak_method_factory_(this) {}
142 if (TranslateRanker::IsEnabled())
143 TranslateRanker::GetInstance()->FetchModelData(); // Asynchronous.
144 }
145 144
146 base::WeakPtr<TranslateManager> TranslateManager::GetWeakPtr() { 145 base::WeakPtr<TranslateManager> TranslateManager::GetWeakPtr() {
147 return weak_method_factory_.GetWeakPtr(); 146 return weak_method_factory_.GetWeakPtr();
148 } 147 }
149 148
150 void TranslateManager::InitiateTranslation(const std::string& page_lang) { 149 void TranslateManager::InitiateTranslation(const std::string& page_lang) {
151 // TODO(rogerm): Remove ScopedTracker below once crbug.com/646711 is closed. 150 // TODO(rogerm): Remove ScopedTracker below once crbug.com/646711 is closed.
152 tracked_objects::ScopedTracker tracking_profile( 151 tracked_objects::ScopedTracker tracking_profile(
153 FROM_HERE_WITH_EXPLICIT_FUNCTION( 152 FROM_HERE_WITH_EXPLICIT_FUNCTION(
154 "646711 translate::TranslateManager::InitiateTranslation")); 153 "646711 translate::TranslateManager::InitiateTranslation"));
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 TranslateDownloadManager::GetLanguageCode(page_lang); 222 TranslateDownloadManager::GetLanguageCode(page_lang);
224 223
225 InitTranslateEvent(language_code, target_lang, *translate_prefs); 224 InitTranslateEvent(language_code, target_lang, *translate_prefs);
226 225
227 // Don't translate similar languages (ex: en-US to en). 226 // Don't translate similar languages (ex: en-US to en).
228 if (language_code == target_lang) { 227 if (language_code == target_lang) {
229 TranslateBrowserMetrics::ReportInitiationStatus( 228 TranslateBrowserMetrics::ReportInitiationStatus(
230 TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES); 229 TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
231 return; 230 return;
232 } 231 }
232
233 bool ranker_should_offer_translation = true;
234 if (translate_ranker_->IsQueryEnabled() ||
235 translate_ranker_->IsEnforcementEnabled()) {
236 ranker_should_offer_translation = translate_ranker_->ShouldOfferTranslation(
237 *translate_prefs, language_code, target_lang);
238 translate_event_->set_ranker_request_timestamp_sec(
239 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
240 translate_event_->set_ranker_version(translate_ranker_->GetModelVersion());
241 translate_event_->set_ranker_response(
242 ranker_should_offer_translation
243 ? metrics::TranslateEventProto::SHOW
244 : metrics::TranslateEventProto::DONT_SHOW);
245 }
246
233 // Nothing to do if either the language Chrome is in or the language of the 247 // Nothing to do if either the language Chrome is in or the language of the
234 // page is not supported by the translation server. 248 // page is not supported by the translation server.
235 if (target_lang.empty() || 249 if (target_lang.empty() ||
236 !TranslateDownloadManager::IsSupportedLanguage(language_code)) { 250 !TranslateDownloadManager::IsSupportedLanguage(language_code)) {
237 TranslateBrowserMetrics::ReportInitiationStatus( 251 TranslateBrowserMetrics::ReportInitiationStatus(
238 TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED); 252 TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED);
239 TranslateBrowserMetrics::ReportUnsupportedLanguageAtInitiation( 253 TranslateBrowserMetrics::ReportUnsupportedLanguageAtInitiation(
240 language_code); 254 language_code);
241 RecordTranslateEvent(metrics::TranslateEventProto::UNSUPPORTED_LANGUAGE); 255 RecordTranslateEvent(metrics::TranslateEventProto::UNSUPPORTED_LANGUAGE);
242 return; 256 return;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 return; 307 return;
294 } 308 }
295 309
296 if (LanguageInULP(language_code)) { 310 if (LanguageInULP(language_code)) {
297 TranslateBrowserMetrics::ReportInitiationStatus( 311 TranslateBrowserMetrics::ReportInitiationStatus(
298 TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IN_ULP); 312 TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IN_ULP);
299 RecordTranslateEvent(metrics::TranslateEventProto::LANGUAGE_IN_ULP); 313 RecordTranslateEvent(metrics::TranslateEventProto::LANGUAGE_IN_ULP);
300 return; 314 return;
301 } 315 }
302 316
303 if (TranslateRanker::IsEnabled()) { 317 if (!ranker_should_offer_translation &&
304 TranslateRanker* translate_ranker = TranslateRanker::GetInstance(); 318 translate_ranker_->IsEnforcementEnabled()) {
305 bool should_offer_translation = translate_ranker->ShouldOfferTranslation( 319 TranslateBrowserMetrics::ReportInitiationStatus(
306 *translate_prefs, language_code, target_lang); 320 TranslateBrowserMetrics::INITIATION_STATUS_ABORTED_BY_RANKER);
307 translate_event_->set_ranker_request_timestamp_sec( 321 RecordTranslateEvent(metrics::TranslateEventProto::DISABLED_BY_RANKER);
308 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds()); 322 return;
309 translate_event_->set_ranker_version(translate_ranker->GetModelVersion());
310 translate_event_->set_ranker_response(
311 should_offer_translation ? metrics::TranslateEventProto::SHOW
312 : metrics::TranslateEventProto::DONT_SHOW);
313 if (!should_offer_translation && TranslateRanker::IsEnforcementEnabled()) {
314 TranslateBrowserMetrics::ReportInitiationStatus(
315 TranslateBrowserMetrics::INITIATION_STATUS_ABORTED_BY_RANKER);
316 RecordTranslateEvent(metrics::TranslateEventProto::DISABLED_BY_RANKER);
317 return;
318 }
319 } 323 }
320 324
321 TranslateBrowserMetrics::ReportInitiationStatus( 325 TranslateBrowserMetrics::ReportInitiationStatus(
322 TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR); 326 TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR);
323 327
324 // Prompts the user if they want the page translated. 328 // Prompts the user if they want the page translated.
325 translate_client_->ShowTranslateUI(translate::TRANSLATE_STEP_BEFORE_TRANSLATE, 329 translate_client_->ShowTranslateUI(translate::TRANSLATE_STEP_BEFORE_TRANSLATE,
326 language_code, 330 language_code,
327 target_lang, 331 target_lang,
328 TranslateErrors::NONE, 332 TranslateErrors::NONE,
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 translate_event_->set_event_type(metrics::TranslateEventProto::UNKNOWN); 599 translate_event_->set_event_type(metrics::TranslateEventProto::UNKNOWN);
596 // TODO(rogerm): Populate the language list. 600 // TODO(rogerm): Populate the language list.
597 } 601 }
598 602
599 void TranslateManager::RecordTranslateEvent(int event_type) { 603 void TranslateManager::RecordTranslateEvent(int event_type) {
600 DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type)); 604 DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
601 translate_event_->set_event_type( 605 translate_event_->set_event_type(
602 static_cast<metrics::TranslateEventProto::EventType>(event_type)); 606 static_cast<metrics::TranslateEventProto::EventType>(event_type));
603 translate_event_->set_event_timestamp_sec( 607 translate_event_->set_event_timestamp_sec(
604 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds()); 608 (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
605 TranslateRanker::GetInstance()->RecordTranslateEvent(*translate_event_); 609 translate_ranker_->AddTranslateEvent(*translate_event_);
606 } 610 }
607 611
608 } // namespace translate 612 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698