tools/metrics/histograms/histograms.xml - Issue 2785493004: Integrate RankerModelLoader with TranslateRanker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2785493004: Integrate RankerModelLoader with TranslateRanker. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index a08a797caadefaa69ebfc2739e4bfd0fda291e82..3e51f6a3c78e46606bb053a1413cb513bb05fd3b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -73477,8 +73477,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>Counts translation target page schemes.</summary>

</histogram>

-<histogram name="Translate.Ranker.Model.Status"

- enum="TranslateRankerModelStatus">

+<histogram name="Translate.Ranker.Model.Status" enum="RankerModelStatus">

<owner>rogerm@google.com</owner>

Tracks the outcome of attempts to download a Translate Ranker Model.

@@ -108325,6 +108324,15 @@ from previous Chrome versions.

</enum>

+<enum name="RankerModelStatus" type="int">

+ <int value="0" label="OK"/>

+ <int value="1" label="Download Throttled"/>

+ <int value="2" label="Download Failed"/>

+ <int value="3" label="Parse Failed"/>

+ <int value="4" label="Validation Failed"/>

+ <int value="5" label="Incompatible"/>

+</enum>

@@ -113358,14 +113366,6 @@ from previous Chrome versions.

</enum>

-<enum name="TranslateRankerModelStatus" type="int">

- <int value="0" label="OK"/>

- <int value="1" label="Download Throttled"/>

- <int value="2" label="Download Failed"/>

- <int value="3" label="Parse Failed"/>

- <int value="4" label="Validation Failed"/>

rkaplow 2017/04/03 03:14:25 you can actually leave the original enum. You're a

Roger McFarlane (Chromium) 2017/04/03 17:44:55 This change should've landed with https://coderevi

-</enum>