Disable SDCH by Default

chrome/test/data/webui/net_internals/sdch_view.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// TODO(rdsmith) Note that SDCH has been disabled in Chrome as of M59.

[eroman, 2017/03/30 17:00:24]

Please put this in the implementation file rather than the test file.

Other than that, net_internals LGTM

+// This code is being retained for examining dumps generated before that
+// milestone.  It's probably fine to remove it in M64 or later.
+
 // Include test fixture.
 GEN_INCLUDE(['net_internals_test.js']);
 
 // Anonymous namespace
 (function() {
 
 // Path to the page containing iframe. Iframe is used to load sdch-related
 // content from the different origin. Otherwise favicon requests for the main
 // page domain would spoil SDCH blacklists counters making test behavior hardly
 // predicatble.
@@ skipping 152 matching lines @@
       var tableId = SdchView.BLACKLIST_TBODY_ID;
       var domain = NetInternalsTest.getTbodyText(tableId, 0, 0);
       var reason = NetInternalsTest.getTbodyText(tableId, 0, 1);
       expectEquals(entry.domain, domain);
       expectEquals(this.reason_, reason);
       this.onTaskDone();
     }
   }
 };
 
-/**
- * Load a page, which results in downloading a SDCH dictionary. Make sure its
- * data is displayed.
- */
-TEST_F('NetInternalsTest', 'netInternalsSdchViewFetchDictionary', function() {
-  var taskQueue = new NetInternalsTest.TaskQueue(true);
-  taskQueue.addTask(
-      new NetInternalsTest.GetTestServerURLTask(
-          BASE_PATH + encodeURI('/sdch/page.html')));
-  taskQueue.addTask(new LoadSdchDictionaryTask());
-  taskQueue.run();
-});
-
-/**
- * Load a page, get the dictionary for it, and get decoding error to see
- * the blacklist in action.
- */
-TEST_F('NetInternalsTest', 'netInternalsSdchViewBlacklistMeta', function() {
-  var taskQueue = new NetInternalsTest.TaskQueue(true);
-  taskQueue.addTask(
-      new NetInternalsTest.GetTestServerURLTask(
-          BASE_PATH + encodeURI('/sdch/page.html')));
-  taskQueue.addTask(new LoadSdchDictionaryTask());
-  taskQueue.addTask(
-      new NetInternalsTest.GetTestServerURLTask(
-          BASE_PATH + encodeURI('/sdch/non-html')));
-  taskQueue.addTask(
-      new LoadPageWithDecodeErrorTask('META_REFRESH_UNSUPPORTED'));
-  taskQueue.run();
-});
-
-/**
- * Load a page, which is said to be SDCH-encoded, though we don't expect it.
- */
-TEST_F('NetInternalsTest', 'netInternalsSdchViewBlacklistNonSdch', function() {
-  var taskQueue = new NetInternalsTest.TaskQueue(true);
-  taskQueue.addTask(
-      new NetInternalsTest.GetTestServerURLTask(
-          BASE_PATH + encodeURI('/sdch/non-sdch.html')));
-  taskQueue.addTask(
-      new LoadPageWithDecodeErrorTask('PASSING_THROUGH_NON_SDCH'));
-  taskQueue.run();
-});
-
 })();  // Anonymous namespace