views::TableView - request focus on tap.

ui/views/controls/table/table_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/table/table_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 391 matching lines @@
   } else if (event.GetClickCount() == 1) {
     ui::ListSelectionModel new_model;
     ConfigureSelectionModelForEvent(event, &new_model);
     SetSelectionModel(new_model);
   }
 
   return true;
 }
 
 void TableView::OnGestureEvent(ui::GestureEvent* event) {
+  RequestFocus();

[sky, 2017/03/28 17:41:24]

Should we only request focus on ET_GESTURE_TAP_DOWN?

[Evan Stade, 2017/03/28 17:43:17]

I am hoping Terry knows what the standard behavior for focusing on gestures is.
I guessed that it should go here based on OnMousePressed.

[tdanderson, 2017/03/28 21:26:22]

Doing a quick audit of other surfaces it doesn't look like we have a standard
way of focusing with gestures. But for consistency with mouse behavior you
should call RequestFocus() on ET_GESTURE_TAP_DOWN as sky@ suggests (and also
call SetHandled() on the event in this case).

   if (event->type() != ui::ET_GESTURE_TAP)
     return;
 
   const int row = event->y() / row_height_;
   if (row < 0 || row >= RowCount())
     return;
 
   event->StopPropagation();
   ui::ListSelectionModel new_model;
   ConfigureSelectionModelForEvent(*event, &new_model);
@@ skipping 528 matching lines @@
   if (tooltip)
     *tooltip = text;
   if (tooltip_origin) {
     tooltip_origin->SetPoint(cell_bounds.x(),
                              cell_bounds.y() + kTextVerticalPadding);
   }
   return true;
 }
 
 }  // namespace views