Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2793)

Unified Diff: device/bluetooth/bluetooth_device.cc

Issue 2785383002: Update unit tests for BluetoothDevice::GetPrimaryServicesByUUID() etc. (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device.cc
diff --git a/device/bluetooth/bluetooth_device.cc b/device/bluetooth/bluetooth_device.cc
index 665cbb685a68da5afedd3e6cdd60dd8898597fff..a42ae172f1a9013aaeb9ea9addd0c41bde58a115 100644
--- a/device/bluetooth/bluetooth_device.cc
+++ b/device/bluetooth/bluetooth_device.cc
@@ -485,22 +485,6 @@ BluetoothDevice::GetCharacteristicsByUUID(
return characteristics;
}
-std::vector<device::BluetoothRemoteGattDescriptor*>
-BluetoothDevice::GetDescriptorsByUUID(
- device::BluetoothRemoteGattCharacteristic* characteristic,
- const BluetoothUUID& descriptor_uuid) {
- std::vector<device::BluetoothRemoteGattDescriptor*> descriptors;
- DVLOG(1) << "Looking for descriptor: " << descriptor_uuid.canonical_value();
- for (auto* descriptor : characteristic->GetDescriptors()) {
- DVLOG(1) << "Descriptor in cache: "
- << descriptor->GetUUID().canonical_value();
- if (descriptor->GetUUID() == descriptor_uuid) {
- descriptors.push_back(descriptor);
- }
- }
- return descriptors;
-}
-
void BluetoothDevice::DidConnectGatt() {
for (const auto& callback : create_gatt_connection_success_callbacks_) {
callback.Run(

Powered by Google App Engine
This is Rietveld 408576698