Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2785243003: Implement support for single stepping out of an async function. (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement support for single stepping out of an async function. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/193f26d1e13551e6a9df9cde340b0731b9b5edc7

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : fschneider review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -92 lines) Patch
M runtime/observatory/tests/service/async_next_test.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download
A runtime/observatory/tests/service/async_single_step_exception_test.dart View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/async_single_step_out_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
D runtime/observatory/tests/service/smart_next_test.dart View 1 1 chunk +0 lines, -74 lines 0 comments Download
M runtime/observatory/tests/service/step_over_await_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/debugger.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 11 chunks +93 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
3 years, 8 months ago (2017-03-30 18:02:55 UTC) #3
Florian Schneider
https://codereview.chromium.org/2785243003/diff/40001/runtime/observatory/tests/service/async_single_step_out_test.dart File runtime/observatory/tests/service/async_single_step_out_test.dart (right): https://codereview.chromium.org/2785243003/diff/40001/runtime/observatory/tests/service/async_single_step_out_test.dart#newcode27 runtime/observatory/tests/service/async_single_step_out_test.dart:27: await helper(); // LINE_D. Please add a test (in ...
3 years, 8 months ago (2017-03-31 17:39:54 UTC) #4
rmacnak
lgtm
3 years, 8 months ago (2017-03-31 17:42:54 UTC) #5
Cutch
Committed patchset #4 (id:60001) manually as 193f26d1e13551e6a9df9cde340b0731b9b5edc7 (presubmit successful).
3 years, 8 months ago (2017-03-31 17:55:18 UTC) #7
Cutch
https://codereview.chromium.org/2785243003/diff/40001/runtime/observatory/tests/service/async_single_step_out_test.dart File runtime/observatory/tests/service/async_single_step_out_test.dart (right): https://codereview.chromium.org/2785243003/diff/40001/runtime/observatory/tests/service/async_single_step_out_test.dart#newcode27 runtime/observatory/tests/service/async_single_step_out_test.dart:27: await helper(); // LINE_D. On 2017/03/31 17:39:54, Florian Schneider ...
3 years, 8 months ago (2017-03-31 17:55:24 UTC) #8
Florian Schneider
3 years, 8 months ago (2017-03-31 18:02:26 UTC) #9
Message was sent while issue was closed.
lgtm

Thanks.

Powered by Google App Engine
This is Rietveld 408576698