Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 278523005: Remove global SkRandoms from ChartBench. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove global SkRandoms from ChartBench. TSAN picked them up while running DM. BUG=skia:1792 Committed: http://code.google.com/p/skia/source/detail?r=14641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M bench/ChartBench.cpp View 3 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 7 months ago (2014-05-08 12:51:53 UTC) #1
bsalomon
lgtm
6 years, 7 months ago (2014-05-08 13:48:06 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-08 14:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/278523005/1
6 years, 7 months ago (2014-05-08 14:57:44 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 15:12:44 UTC) #5
Message was sent while issue was closed.
Change committed as 14641

Powered by Google App Engine
This is Rietveld 408576698