ios/clean/chrome/browser/ui/commands/tools_menu_commands.h - Issue 2785213003: [ios] Use dispatcher for ToolsMenu commands.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/tools_menu_commands.h

Issue 2785213003: [ios] Use dispatcher for ToolsMenu commands. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/commands/toolbar_commands.h ('k') | ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h » ('j') | ios/clean/chrome/browser/ui/presenters/menu_presentation_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TOOLS_MENU_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TOOLS_MENU_COMMANDS_H_

	7

	8 // Command protocol for commands related to the ToolsMenu.

	9 @protocol ToolsMenuCommands

	10 @optional
	lpromero 2017/03/31 06:34:38 Why @optional? When adding optional methods to a p Why @optional? When adding optional methods to a protocol, it is useful to also make the protocol conform to the NSObject protocol. That way you can do: id<MyProtocol> some = … if ([some respondsToSelector:@selector(protocolMethod)]) { … sczs 2017/03/31 17:32:57 I was thinking about the same. Depending on how we Show quoted text On 2017/03/31 06:34:38, lpromero wrote: > Why @optional? > When adding optional methods to a protocol, it is useful to also make the > protocol conform to the NSObject protocol. That way you can do: > id<MyProtocol> some = … > if ([some respondsToSelector:@selector(protocolMethod)]) { > … I was thinking about the same. Depending on how we group these protocol methods I might change some to required. This because some other Classes/Coordinators only need to implement some of them, like the PresentationController with close, or the TabGrid Menu won't have a shareMenu implementation,etc. Thanks for the NSObject protocol tip, makes a lot of sense!
	11 // Shows the tools menu.

	12 - (void)showToolsMenu;

	13

	14 // Closes the tools menu.

	15 - (void)closeToolsMenu;

	16

	17 // Displays the Share menu.

	18 - (void)showShareMenu;

	19 @end

	20

	21 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TOOLS_MENU_COMMANDS_H_

OLD	NEW