Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278513005: Blink GC plugin: disallow pure-virtual trace methods. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: disallow pure-virtual trace methods. BUG=334149 R=ager@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269547

Patch Set 1 #

Patch Set 2 : remove pure related code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -30 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 5 chunks +21 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/pure_virtual_trace.h View 2 chunks +2 lines, -14 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/pure_virtual_trace.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/pure_virtual_trace.txt View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-08 08:40:22 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-08 08:44:08 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-08 08:44:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/278513005/1
6 years, 7 months ago (2014-05-08 08:47:56 UTC) #4
zerny-chromium
The CQ bit was unchecked by zerny@chromium.org
6 years, 7 months ago (2014-05-08 08:51:08 UTC) #5
zerny-chromium
Updated to also remove the "pure virtual" related special casing.
6 years, 7 months ago (2014-05-08 09:15:44 UTC) #6
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-08 09:16:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/278513005/20001
6 years, 7 months ago (2014-05-08 09:19:30 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 15:08:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 00:15:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/13794)
6 years, 7 months ago (2014-05-09 00:15:26 UTC) #11
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-09 06:04:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/278513005/20001
6 years, 7 months ago (2014-05-09 06:09:47 UTC) #13
zerny-chromium
The CQ bit was unchecked by zerny@chromium.org
6 years, 7 months ago (2014-05-09 09:39:42 UTC) #14
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-09 10:19:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/278513005/20001
6 years, 7 months ago (2014-05-09 10:24:01 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 06:31:17 UTC) #17
Message was sent while issue was closed. 
Change committed as 269547

Powered by Google App Engine
This is Rietveld 408576698