Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/child/webcrypto/shared_crypto.h

Issue 278513004: [webcrypto] Fix a race in BlinkPlatformImpl::crypto(), by using eager initilization of WebCryptoImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do initialization as part of crypto() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/shared_crypto.h
diff --git a/content/child/webcrypto/shared_crypto.h b/content/child/webcrypto/shared_crypto.h
index 3af025f000cbb397423af945859223ac3e0a99e7..1e5b50773a1fa58c23b1d6cd588959419d493865 100644
--- a/content/child/webcrypto/shared_crypto.h
+++ b/content/child/webcrypto/shared_crypto.h
@@ -21,7 +21,8 @@ namespace webcrypto {
class CryptoData;
class Status;
-// Do one-time initialization. It is safe to call this multiple times.
+// Do lazy initialization. It should be safe to call this multiple times and
+// from concurrent threads.
Ryan Sleevi 2014/05/13 05:47:20 lazy vs one-time is an artifact of how it's used,
eroman 2014/05/13 18:27:15 Changed back to original comment, but with a menti
CONTENT_EXPORT void Init();
// The functions exported by shared_crypto.h provide a common entry point for

Powered by Google App Engine
This is Rietveld 408576698