Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2785123003: Refactor hex parsing in SpdyAltSvcWireFormat. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 8 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor hex parsing in SpdyAltSvcWireFormat. base/strings/string_util.h is not available in the internal codebase (and nor is net/base/parse_number.h). This CL changes SpdyAltSvcWireFormat to use std::isxdigit() instead of base::IsHexDigit(), which is identical. It refactors base::HexDigitToInt() into spdy/platform/, so that the internal code can roll its own implementation. This makes spdy_alt_svc_wire_format.cc almost byte-to-byte identical between the two codebases. This CL lands server side change 151758530 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2785123003 Cr-Commit-Position: refs/heads/master@{#461117} Committed: https://chromium.googlesource.com/chromium/src/+/fb576715612dc3343c188f0b76661f169021e5dd

Patch Set 1 #

Total comments: 1

Patch Set 2 : Factor out HexDigitToInt into spdy/platform/. #

Patch Set 3 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M net/spdy/platform/api/spdy_string_utils.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/platform/api/spdy_string_utils_test.cc View 1 4 chunks +31 lines, -4 lines 0 comments Download
M net/spdy/platform/impl/spdy_string_utils_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 1 2 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Bence
https://codereview.chromium.org/2785123003/diff/1/net/spdy/spdy_alt_svc_wire_format.cc File net/spdy/spdy_alt_svc_wire_format.cc (left): https://codereview.chromium.org/2785123003/diff/1/net/spdy/spdy_alt_svc_wire_format.cc#oldcode24 net/spdy/spdy_alt_svc_wire_format.cc:24: // TODO(mmenke): This really should be using methods in ...
3 years, 8 months ago (2017-03-30 19:12:34 UTC) #8
Bence
xunjieli: PTAL. This is a follow-up to https://crrev.com/2778043004.
3 years, 8 months ago (2017-03-30 20:21:04 UTC) #13
xunjieli
On 2017/03/30 20:21:04, Bence wrote: > xunjieli: PTAL. This is a follow-up to https://crrev.com/2778043004. lgtm
3 years, 8 months ago (2017-03-31 13:33:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785123003/40001
3 years, 8 months ago (2017-03-31 14:07:20 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:39:04 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb576715612dc3343c188f0b7666...

Powered by Google App Engine
This is Rietveld 408576698