chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h - Issue 2785083002: Use devtools to set user agent in chromedriver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h

Issue 2785083002: Use devtools to set user agent in chromedriver (Closed)

Patch Set: Fix New Tab test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_http_client.cc ('k') | chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h

diff --git a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h

index 90c85efd566d9baca2aa3010778f708501c92eaf..e0286a6985dcdd683381ba3a369feffb604fb660 100644

--- a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h

+++ b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h

@@ -25,7 +25,8 @@ class Status;

class MobileEmulationOverrideManager : public DevToolsEventListener {

public:

MobileEmulationOverrideManager(DevToolsClient* client,

- const DeviceMetrics* device_metrics);

+ const DeviceMetrics* device_metrics,

+ std::string user_agent);

~MobileEmulationOverrideManager() override;

// Overridden from DevToolsEventListener:

@@ -41,6 +42,7 @@ class MobileEmulationOverrideManager : public DevToolsEventListener {

DevToolsClient* client_;

const DeviceMetrics* overridden_device_metrics_;

+ const std::string overridden_user_agent_;

DISALLOW_COPY_AND_ASSIGN(MobileEmulationOverrideManager);

};