Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2251)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.h

Issue 2785083002: Use devtools to set user agent in chromedriver (Closed)
Patch Set: Fix New Tab test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_http_client.h
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.h b/chrome/test/chromedriver/chrome/devtools_http_client.h
index b2182fff14c0b9e7b7b16bdc953219ec3bd76576..6edf0c78613cabca2471ba1a6e9ca1b288f8ebff 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.h
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.h
@@ -79,7 +79,8 @@ class DevToolsHttpClient {
const SyncWebSocketFactory& socket_factory,
std::unique_ptr<DeviceMetrics> device_metrics,
std::unique_ptr<std::set<WebViewInfo::Type>> window_types,
- std::string page_load_strategy);
+ std::string page_load_strategy,
+ std::string user_agent);
~DevToolsHttpClient();
Status Init(const base::TimeDelta& timeout);
@@ -95,6 +96,7 @@ class DevToolsHttpClient {
const BrowserInfo* browser_info();
const DeviceMetrics* device_metrics();
bool IsBrowserWindow(const WebViewInfo& view) const;
+ const std::string& user_agent() const;
private:
Status CloseFrontends(const std::string& for_client_id);
@@ -110,6 +112,7 @@ class DevToolsHttpClient {
std::unique_ptr<DeviceMetrics> device_metrics_;
std::unique_ptr<std::set<WebViewInfo::Type>> window_types_;
std::string page_load_strategy_;
+ std::string user_agent_;
DISALLOW_COPY_AND_ASSIGN(DevToolsHttpClient);
};
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698