Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2785063002: Make browsing context keywords case-insensitive. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CreateWindow.cpp
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp
index 755cb5ec5747f5e206c5eb700715f0f8f83adb8f..cd20692992cc7b9e947d73a294703934fb141106 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp
+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp
@@ -50,11 +50,11 @@ static Frame* reuseExistingWindow(LocalFrame& activeFrame,
LocalFrame& lookupFrame,
const AtomicString& frameName,
NavigationPolicy policy) {
- if (!frameName.isEmpty() && frameName != "_blank" &&
+ if (!frameName.isEmpty() && !equalIgnoringCase(frameName, "_blank") &&
policy == NavigationPolicyIgnore) {
if (Frame* frame =
lookupFrame.findFrameForNavigation(frameName, activeFrame)) {
- if (frameName != "_self") {
+ if (!equalIgnoringCase(frameName, "_self")) {
if (Page* page = frame->page()) {
if (page == activeFrame.page())
page->focusController().setFocusedFrame(frame);
@@ -85,7 +85,7 @@ static Frame* createNewWindow(LocalFrame& openerFrame,
ASSERT(page->mainFrame());
LocalFrame& frame = *toLocalFrame(page->mainFrame());
- if (request.frameName() != "_blank")
+ if (!equalIgnoringCase(request.frameName(), "_blank"))
frame.tree().setName(request.frameName());
page->chromeClient().setWindowFeatures(features);

Powered by Google App Engine
This is Rietveld 408576698