Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp

Issue 2785033004: Update comment on overspecified font-variation-settings (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
index a93d6d9802b3fbe775fba7b5424733643b8c2e6f..b38c1e1b9b7b8e3787501de809fe77f6f30d6037 100644
--- a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
@@ -63,12 +63,14 @@ FontPlatformData FontCustomPlatformData::fontPlatformData(
sk_sp<SkTypeface> returnTypeface = m_baseTypeface;
- // Maximum axis count is maximum value for the OpenType USHORT, which is a
- // 16bit unsigned. https://www.microsoft.com/typography/otspec/fvar.htm
- // Variation settings coming from CSS can have duplicate assignments and the
- // list can be longer than UINT16_MAX, but ignoring this for now, going with a
- // reasonable upper limit and leaving the deduplication for TODO(drott),
- // crbug.com/674878 second duplicate value should supersede first..
+ // Maximum axis count is maximum value for the OpenType USHORT,
+ // which is a 16bit unsigned.
+ // https://www.microsoft.com/typography/otspec/fvar.htm Variation
+ // settings coming from CSS can have duplicate assignments and the
+ // list can be longer than UINT16_MAX, but ignoring the length for
+ // now, going with a reasonable upper limit. Deduplication is
+ // handled by Skia with priority given to the last occuring
+ // assignment.
if (variationSettings && variationSettings->size() < UINT16_MAX) {
#if OS(WIN)
sk_sp<SkFontMgr> fm(SkFontMgr_New_Custom_Empty());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698