MD Settings: Google Play Store: Add subpage and polish

chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html

Index: chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_page.html b/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
similarity index 62%
copy from chrome/browser/resources/settings/android_apps_page/android_apps_page.html
copy to chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
index e8bbd3cab2021d1db80b93546f07e5cc7a34bb2e..dd49f1d15f483f7ee02c6620aa8686cbfb10d8f8 100644
--- a/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
@@ -2,37 +2,15 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="android_apps_browser_proxy.html">
-<link rel="import" href="../controls/settings_toggle_button.html">
 <link rel="import" href="../i18n_setup.html">
 <link rel="import" href="../prefs/prefs_behavior.html">
 <link rel="import" href="../settings_shared_css.html">
 
-<dom-module id="settings-android-apps-page">
+<dom-module id="settings-android-apps-subpage">
   <template>
-    <style include="settings-shared">
-      a {
-        -webkit-margin-start: 4px;
-      }
+    <style include="settings-shared"></style>
 
-      .indented {
-        -webkit-margin-start: var(--settings-indent-width);
-      }
-    </style>
-
-    <div class="settings-box first">
-      <settings-toggle-button id="enabled" class="start"
-          pref="{{prefs.arc.enabled}}"
-          label="$i18n{androidAppsEnabled}"
-          on-settings-boolean-control-change="onArcEnabledChange_"
-          no-set-pref>
-        <a href="$i18nRaw{androidAppsLearnMoreUrl}" target="_blank"
-            class="more-actions" on-tap="stopPropagation_">
-          $i18n{androidAppsLearnMore}
-        </a>
-      </settings-toggle-button>
-    </div>
-
-    <div id="manageApps" class="settings-box continuation indented"
+    <div id="manageApps" class="settings-box first"
         on-keydown="onManageAndroidAppsKeydown_"
         on-tap="onManageAndroidAppsTap_" actionable
         hidden="[[!androidAppsInfo_.appReady]]">
@@ -43,6 +21,16 @@
       </button>
     </div>
 
+    <template is="dom-if" if="[[allowRemove_(prefs.arc.enabled.*)]]">
+      <div id="android-apps" class="settings-box" actionable
+          on-tap="onRemoveTap_">

[Dan Beam, 2017/03/30 13:24:22]

most of our code uses the naming convention: onIdNameTap_, as in:
onAndroidAppsTap_, but I don't really know why this ID even exists.  is it used?

[stevenjb, 2017/03/30 23:05:36]

Renamed. The id is used in the (now updated) tests.

+        <div class="start">$i18n{androidAppsRemove}</div>
+        <button class="subpage-arrow" is="paper-icon-button-light"
+            aria-label="$i18n{androidAppsRemove}">
+        </button>
+      </div>
+    </template>
+
     <!-- Confirm disable android apps dialog -->
     <dialog is="cr-dialog" id="confirmDisableDialog" close-text="$i18n{close}"
         on-cancel="onConfirmDisableDialogCancel_">
@@ -59,6 +47,7 @@
         </paper-button>
       </div>
     </dialog>
+
   </template>
-  <script src="android_apps_page.js"></script>
+  <script src="android_apps_subpage.js"></script>
 </dom-module>