Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/app/settings_strings.grdp

Issue 2785013003: MD Settings: Google Play Store: Add subpage and polish (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index 5d79e46473d4165717cb85d1be79cb21ae49cbe4..656de0f3ab01deb488d9f5ba2cfc7c1f6abc6b8a 100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -211,11 +211,17 @@
<message name="IDS_SETTINGS_ANDROID_APPS_TITLE" desc="The title of Google Play Store (Arc++ / Android Apps) section.">
Google Play Store (beta)
</message>
- <message name="IDS_SETTINGS_ANDROID_APPS_ENABLE" desc="Label for the checkbox that enables Google Play Store (Arc++) apps.">
- Enable Google Play Store on your Chromebook.
+ <message name="IDS_SETTINGS_ANDROID_APPS_ENABLE" desc="Label for the button that enables Google Play Store (Arc++) apps.">
+ Turn on
+ </message>
+ <message name="IDS_SETTINGS_ANDROID_APPS_SUBTEXT" desc="Description for the section for enabling and managing Google Play Store (Android) apps.">
+ Install apps and games from Google Play. <ph name="BEGIN_LINK">&lt;a target="_blank" href="$1"&gt;</ph>Learn more<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
Dan Beam 2017/03/30 13:24:22 these <ph> are a little odd to me. can we just ma
stevenjb 2017/03/30 23:05:36 I agree this looks better. FWIW, this is the patte
Dan Beam 2017/03/30 23:35:19 people will keep copy pasting the ones that don't
</message>
<message name="IDS_SETTINGS_ANDROID_APPS_MANAGE_APPS" desc="Label for launching Android apps settings.">
- Manage your Android preferences
+ Manage Android preferences
+ </message>
+ <message name="IDS_SETTINGS_ANDROID_APPS_REMOVE" desc="Label for the control to open a dialog confirming removal of the Google Play Store.">
+ Remove Google Play Store
</message>
<message name="IDS_SETTINGS_ANDROID_APPS_LEARN_MORE" desc="Link for more informaiton about installing Android apps on Chrome OS.">
Learn more
@@ -225,11 +231,9 @@
Remove Android apps?
</message>
<message name="IDS_SETTINGS_ANDROID_APPS_DISABLE_DIALOG_MESSAGE" desc="Describes what will happen if the user opts out of android apps.">
- Apps you’ve downloaded from Google Play will be deleted from this Chromebook.
- <ph name="LINE_BREAKS1">&lt;br&gt;&lt;br&gt;</ph>
- Content you’ve purchased such as movies, TV shows, music, books, or other in-app purchases may also be deleted.
- <ph name="LINE_BREAKS2">&lt;br&gt;&lt;br&gt;</ph>
- This doesn’t affect apps or content on other devices.
+ Apps and content from Google Play will be deleted from your Chromebook.
+ This only affects apps and content on this device.
+ <ph name="BEGIN_LINK">&lt;a target="_blank" href="$1"&gt;</ph>Learn more<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
Dan Beam 2017/03/30 13:24:22 same note regarding <ph>, I don't think they're th
stevenjb 2017/03/30 23:05:36 Done.
</message>
</if>

Powered by Google App Engine
This is Rietveld 408576698